[stable30] fix(TaskProcessing): Refactor TextToImage fallback#58427
Open
backportbot[bot] wants to merge 4 commits intostable30from
Open
[stable30] fix(TaskProcessing): Refactor TextToImage fallback#58427backportbot[bot] wants to merge 4 commits intostable30from
backportbot[bot] wants to merge 4 commits intostable30from
Conversation
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
instead of UserFacingProcessing Exception which is not in nc < 33 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
github-actions
bot
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
@marcelklehr the backport had some issues |
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
backport/58112/stable30
branch
from
ca686ac to
b877312
Compare
Member
|
Seems fixed now, although some CI checks still fail :/ |
| $newProvider = new class($oldProvider, $this->appData, $this->l10nFactory, $userManager) implements IProvider, ISynchronousProvider { | ||
| private \OCP\TextToImage\IProvider $provider; | ||
| private IAppData $appData; | ||
| private IFactory $l10nFactory; |
Member
There was a problem hiding this comment.
I tried to keep the code as similar to the master version as possible, that's why I left it in there. but we can remove it, sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #58112