Closed
Conversation
Signed-off-by: Louis Chmn <louis@chmn.me>
CarlSchwan
approved these changes
Feb 3, 2026
nickvergessen
requested changes
Feb 3, 2026
Member
There was a problem hiding this comment.
- Has to wait for green CI from nextcloud/server side to make sure this does not break something in parallel
- Ref nextcloud/server#57910
- Ref #16947
| public function getUsersWithAccessFile(string $fileId): array { | ||
| if (!isset($this->accessLists[$fileId])) { | ||
| $nodes = $this->rootFolder->getById((int)$fileId); | ||
| $node = $this->rootFolder->getFirstNodeById((int)$fileId); |
Member
There was a problem hiding this comment.
- Here we planned to use IUserFolder instead in fix(filesintegration): Use UserFolder to check for access #16891
But not sure what is better.
Contributor
Author
There was a problem hiding this comment.
The combination of both would be best, IUserFolder + getFirstNodeById.
But using getFirstNodeById should already help.
Contributor
Author
There was a problem hiding this comment.
I only did the easy no-brainer change, as using IUserFolder requires looking at the logic itself to understand whether it fit the situation
This was referenced Feb 3, 2026
Member
Member
|
Merged via #16947 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.