Skip to content

Refactor/db

Refactor/db #14

Triggered via pull request January 12, 2024 09:42
Status Failure
Total duration 1m 36s
Artifacts

psalm-matrix.yml

on: pull_request
Matrix: static-analysis
static-psalm-analysis-summary
5s
static-psalm-analysis-summary
Fit to window
Zoom out
Zoom in

Annotations

15 errors and 20 warnings
InvalidReturnType: lib/Db/View.php#L123
lib/Db/View.php:123:19: InvalidReturnType: The declared return type 'array{columns: array<array-key, int>, createdAt: string, createdBy: string, description: null|string, emoji: null|string, filter: list{int, array{columnId: int, operator: 'begins-with'|'contains'|'ends-with'|'is-empty'|'is-equal'|'is-greater-than'|'is-greater-than-or-equal'|'is-lower-than'|'is-lower-than-or-equal', value: float|int|string}}|null, hasShares: bool, id: int, isShared: bool, lastEditAt: string, lastEditBy: string, onSharePermissions: array{create: bool, delete: bool, manage: bool, read: bool, update: bool}|null, ownerDisplayName: null|string, ownership: string, rowsCount: int, sort: list{int, array{columnId: int, mode: 'ASC'|'DESC'}}|null, tableId: int, title: string}' for OCA\Tables\Db\View::jsonSerialize is incorrect, got 'array{columns: array<array-key, int>, createdAt: string, createdBy: string, description: null|string, emoji: null|string, filter: list<list<array{columnId: int, operator: 'begins-with'|'contains'|'ends-with'|'is-empty'|'is-equal'|'is-greater-than'|'is-greater-than-or-equal'|'is-lower-than'|'is-lower-than-or-equal', value: float|int|string}>>, hasShares: bool, id: int, isShared: bool, lastEditAt: string, lastEditBy: string, onSharePermissions: array{create: bool, delete: bool, manage: bool, read: bool, update: bool}|null, ownerDisplayName: null|string, ownership: string, rowsCount: int, sort: list<array{columnId: int, mode: 'ASC'|'DESC'}>, tableId: int, title: string}' (see https://psalm.dev/011)
InvalidReturnStatement: lib/Db/View.php#L147
lib/Db/View.php:147:10: InvalidReturnStatement: The inferred type 'array{columns: array<array-key, int>, createdAt: string, createdBy: string, description: null|string, emoji: null|string, filter: list<list<array{columnId: int, operator: 'begins-with'|'contains'|'ends-with'|'is-empty'|'is-equal'|'is-greater-than'|'is-greater-than-or-equal'|'is-lower-than'|'is-lower-than-or-equal', value: float|int|string}>>, hasShares: bool, id: int, isShared: bool, lastEditAt: string, lastEditBy: string, onSharePermissions: array{create: bool, delete: bool, manage: bool, read: bool, update: bool}|null, ownerDisplayName: null|string, ownership: string, rowsCount: int, sort: list<array{columnId: int, mode: 'ASC'|'DESC'}>, tableId: int, title: string}' does not match the declared return type 'array{columns: array<array-key, int>, createdAt: string, createdBy: string, description: null|string, emoji: null|string, filter: list{int, array{columnId: int, operator: 'begins-with'|'contains'|'ends-with'|'is-empty'|'is-equal'|'is-greater-than'|'is-greater-than-or-equal'|'is-lower-than'|'is-lower-than-or-equal', value: float|int|string}}|null, hasShares: bool, id: int, isShared: bool, lastEditAt: string, lastEditBy: string, onSharePermissions: array{create: bool, delete: bool, manage: bool, read: bool, update: bool}|null, ownerDisplayName: null|string, ownership: string, rowsCount: int, sort: list{int, array{columnId: int, mode: 'ASC'|'DESC'}}|null, tableId: int, title: string}' for OCA\Tables\Db\View::jsonSerialize (see https://psalm.dev/128)
UndefinedVariable: lib/Service/RowService.php#L187
lib/Service/RowService.php:187:92: UndefinedVariable: Cannot find referenced variable $e (see https://psalm.dev/024)
UndefinedVariable: lib/Service/RowService.php#L187
lib/Service/RowService.php:187:107: UndefinedVariable: Cannot find referenced variable $e (see https://psalm.dev/024)
UndefinedVariable: lib/Service/RowService.php#L192
lib/Service/RowService.php:192:82: UndefinedVariable: Cannot find referenced variable $e (see https://psalm.dev/024)
UndefinedVariable: lib/Service/RowService.php#L192
lib/Service/RowService.php:192:97: UndefinedVariable: Cannot find referenced variable $e (see https://psalm.dev/024)
static-psalm-analysis dev-master
Process completed with exit code 2.
InvalidReturnType: lib/Db/View.php#L123
lib/Db/View.php:123:19: InvalidReturnType: The declared return type 'array{columns: array<array-key, int>, createdAt: string, createdBy: string, description: null|string, emoji: null|string, filter: list{int, array{columnId: int, operator: 'begins-with'|'contains'|'ends-with'|'is-empty'|'is-equal'|'is-greater-than'|'is-greater-than-or-equal'|'is-lower-than'|'is-lower-than-or-equal', value: float|int|string}}|null, hasShares: bool, id: int, isShared: bool, lastEditAt: string, lastEditBy: string, onSharePermissions: array{create: bool, delete: bool, manage: bool, read: bool, update: bool}|null, ownerDisplayName: null|string, ownership: string, rowsCount: int, sort: list{int, array{columnId: int, mode: 'ASC'|'DESC'}}|null, tableId: int, title: string}' for OCA\Tables\Db\View::jsonSerialize is incorrect, got 'array{columns: array<array-key, int>, createdAt: string, createdBy: string, description: null|string, emoji: null|string, filter: list<list<array{columnId: int, operator: 'begins-with'|'contains'|'ends-with'|'is-empty'|'is-equal'|'is-greater-than'|'is-greater-than-or-equal'|'is-lower-than'|'is-lower-than-or-equal', value: float|int|string}>>, hasShares: bool, id: int, isShared: bool, lastEditAt: string, lastEditBy: string, onSharePermissions: array{create: bool, delete: bool, manage: bool, read: bool, update: bool}|null, ownerDisplayName: null|string, ownership: string, rowsCount: int, sort: list<array{columnId: int, mode: 'ASC'|'DESC'}>, tableId: int, title: string}' (see https://psalm.dev/011)
InvalidReturnStatement: lib/Db/View.php#L147
lib/Db/View.php:147:10: InvalidReturnStatement: The inferred type 'array{columns: array<array-key, int>, createdAt: string, createdBy: string, description: null|string, emoji: null|string, filter: list<list<array{columnId: int, operator: 'begins-with'|'contains'|'ends-with'|'is-empty'|'is-equal'|'is-greater-than'|'is-greater-than-or-equal'|'is-lower-than'|'is-lower-than-or-equal', value: float|int|string}>>, hasShares: bool, id: int, isShared: bool, lastEditAt: string, lastEditBy: string, onSharePermissions: array{create: bool, delete: bool, manage: bool, read: bool, update: bool}|null, ownerDisplayName: null|string, ownership: string, rowsCount: int, sort: list<array{columnId: int, mode: 'ASC'|'DESC'}>, tableId: int, title: string}' does not match the declared return type 'array{columns: array<array-key, int>, createdAt: string, createdBy: string, description: null|string, emoji: null|string, filter: list{int, array{columnId: int, operator: 'begins-with'|'contains'|'ends-with'|'is-empty'|'is-equal'|'is-greater-than'|'is-greater-than-or-equal'|'is-lower-than'|'is-lower-than-or-equal', value: float|int|string}}|null, hasShares: bool, id: int, isShared: bool, lastEditAt: string, lastEditBy: string, onSharePermissions: array{create: bool, delete: bool, manage: bool, read: bool, update: bool}|null, ownerDisplayName: null|string, ownership: string, rowsCount: int, sort: list{int, array{columnId: int, mode: 'ASC'|'DESC'}}|null, tableId: int, title: string}' for OCA\Tables\Db\View::jsonSerialize (see https://psalm.dev/128)
UndefinedVariable: lib/Service/RowService.php#L187
lib/Service/RowService.php:187:92: UndefinedVariable: Cannot find referenced variable $e (see https://psalm.dev/024)
UndefinedVariable: lib/Service/RowService.php#L187
lib/Service/RowService.php:187:107: UndefinedVariable: Cannot find referenced variable $e (see https://psalm.dev/024)
UndefinedVariable: lib/Service/RowService.php#L192
lib/Service/RowService.php:192:82: UndefinedVariable: Cannot find referenced variable $e (see https://psalm.dev/024)
UndefinedVariable: lib/Service/RowService.php#L192
lib/Service/RowService.php:192:97: UndefinedVariable: Cannot find referenced variable $e (see https://psalm.dev/024)
static-psalm-analysis dev-stable28
Process completed with exit code 2.
static-psalm-analysis-summary
Process completed with exit code 1.
PossiblyNullArgument: lib/Api/V1Api.php#L43
lib/Api/V1Api.php:43:54: PossiblyNullArgument: Argument 2 of OCA\Tables\Service\RowService::findAllByView cannot be null, possibly null value provided (see https://psalm.dev/078)
PossiblyNullArgument: lib/Api/V1Api.php#L47
lib/Api/V1Api.php:47:55: PossiblyNullArgument: Argument 2 of OCA\Tables\Service\RowService::findAllByTable cannot be null, possibly null value provided (see https://psalm.dev/078)
PossiblyNullIterator: lib/Api/V1Api.php#L65
lib/Api/V1Api.php:65:14: PossiblyNullIterator: Cannot iterate over nullable var array<array-key, mixed>|null (see https://psalm.dev/097)
PropertyNotSetInConstructor: lib/Command/Clean.php#L59
lib/Command/Clean.php:59:26: PropertyNotSetInConstructor: Property OCA\Tables\Command\Clean::$output is not defined in constructor of OCA\Tables\Command\Clean or in any private or final methods called in the constructor (see https://psalm.dev/074)
PossiblyNullArgument: lib/Command/Clean.php#L116
lib/Command/Clean.php:116:52: PossiblyNullArgument: Argument 1 of OCA\Tables\Service\ColumnService::findAllByTable cannot be null, possibly null value provided (see https://psalm.dev/078)
PossiblyNullPropertyAssignmentValue: lib/Command/Clean.php#L118
lib/Command/Clean.php:118:20: PossiblyNullPropertyAssignmentValue: $this->offset with non-nullable declared type 'int' cannot be assigned nullable type 'int|null' (see https://psalm.dev/148)
PossiblyNullOperand: lib/Command/Clean.php#L137
lib/Command/Clean.php:137:47: PossiblyNullOperand: Cannot concatenate with a possibly null int|null (see https://psalm.dev/080)
PossiblyNullIterator: lib/Command/Clean.php#L147
lib/Command/Clean.php:147:12: PossiblyNullIterator: Cannot iterate over nullable var array<array-key, mixed>|null (see https://psalm.dev/097)
PossiblyNullReference: lib/Command/Clean.php#L147
lib/Command/Clean.php:147:24: PossiblyNullReference: Cannot call method getData on possibly null value (see https://psalm.dev/083)
PossiblyNullOperand: lib/Command/Clean.php#L165
lib/Command/Clean.php:165:87: PossiblyNullOperand: Cannot concatenate with a possibly null int|null (see https://psalm.dev/080)
PossiblyNullArgument: lib/Api/V1Api.php#L43
lib/Api/V1Api.php:43:54: PossiblyNullArgument: Argument 2 of OCA\Tables\Service\RowService::findAllByView cannot be null, possibly null value provided (see https://psalm.dev/078)
PossiblyNullArgument: lib/Api/V1Api.php#L47
lib/Api/V1Api.php:47:55: PossiblyNullArgument: Argument 2 of OCA\Tables\Service\RowService::findAllByTable cannot be null, possibly null value provided (see https://psalm.dev/078)
PossiblyNullIterator: lib/Api/V1Api.php#L65
lib/Api/V1Api.php:65:14: PossiblyNullIterator: Cannot iterate over nullable var array<array-key, mixed>|null (see https://psalm.dev/097)
PropertyNotSetInConstructor: lib/Command/Clean.php#L59
lib/Command/Clean.php:59:26: PropertyNotSetInConstructor: Property OCA\Tables\Command\Clean::$output is not defined in constructor of OCA\Tables\Command\Clean or in any private or final methods called in the constructor (see https://psalm.dev/074)
PossiblyNullArgument: lib/Command/Clean.php#L116
lib/Command/Clean.php:116:52: PossiblyNullArgument: Argument 1 of OCA\Tables\Service\ColumnService::findAllByTable cannot be null, possibly null value provided (see https://psalm.dev/078)
PossiblyNullPropertyAssignmentValue: lib/Command/Clean.php#L118
lib/Command/Clean.php:118:20: PossiblyNullPropertyAssignmentValue: $this->offset with non-nullable declared type 'int' cannot be assigned nullable type 'int|null' (see https://psalm.dev/148)
PossiblyNullOperand: lib/Command/Clean.php#L137
lib/Command/Clean.php:137:47: PossiblyNullOperand: Cannot concatenate with a possibly null int|null (see https://psalm.dev/080)
PossiblyNullIterator: lib/Command/Clean.php#L147
lib/Command/Clean.php:147:12: PossiblyNullIterator: Cannot iterate over nullable var array<array-key, mixed>|null (see https://psalm.dev/097)
PossiblyNullReference: lib/Command/Clean.php#L147
lib/Command/Clean.php:147:24: PossiblyNullReference: Cannot call method getData on possibly null value (see https://psalm.dev/083)
PossiblyNullOperand: lib/Command/Clean.php#L165
lib/Command/Clean.php:165:87: PossiblyNullOperand: Cannot concatenate with a possibly null int|null (see https://psalm.dev/080)