fix(Contexts): fix return code when context not found

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
nextcloud · Mar 6, 2024 · 0d141de · 0d141de
1 parent 5660cf7
commit 0d141de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/Controller/ContextController.php b/lib/Controller/ContextController.php
@@ -72,6 +72,8 @@ public function show(int $contextId): DataResponse {
 		try {
 			$context = $this->contextService->findById($contextId, $this->userId);
 			return new DataResponse($context->jsonSerialize());
+		} catch (NotFoundError $e) {
+			return $this->handleNotFoundError($e);
 		} catch (InternalError|Exception $e) {
 			return $this->handleError($e);
 		}

diff --git a/lib/Db/ContextMapper.php b/lib/Db/ContextMapper.php
@@ -4,6 +4,7 @@
 
 namespace OCA\Tables\Db;
 
+use OCA\Tables\Errors\NotFoundError;
 use OCA\Tables\Helper\UserHelper;
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Db\MultipleObjectsReturnedException;
@@ -172,6 +173,10 @@ public function findById(int $contextId, ?string $userId = null): Context {
 		$result = $qb->executeQuery();
 		$r = $result->fetchAll();
 
+		if (empty($r)) {
+			throw new NotFoundError('Context does not exist');
+		}
+
 		return $this->formatResultRows($r, $userId);
 	}