chore: Move meta column identifiers to constants

Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Apr 25, 2024 · 8d33235 · 8d33235
1 parent a026d6e
commit 8d33235
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/lib/Db/Column.php b/lib/Db/Column.php
@@ -62,6 +62,13 @@
  * @method setDatetimeDefault(?string $datetimeDefault)
  */
 class Column extends Entity implements JsonSerializable {
+	// Meta column types
+	public const TYPE_META_ID = -1;
+	public const TYPE_META_CREATED = -2;
+	public const TYPE_META_CREATED_AT = -3;
+	public const TYPE_META_UPDATED = -4;
+	public const TYPE_META_UPDATED_AT = -5;
+
 	public const TYPE_SELECTION = 'selection';
 	public const TYPE_TEXT = 'text';
 	public const TYPE_NUMBER = 'number';

diff --git a/lib/Db/Row2Mapper.php b/lib/Db/Row2Mapper.php
@@ -407,19 +407,19 @@ private function getMetaFilterExpression(IQueryBuilder $qb, int $columnId, strin
 		$qb2->from('tables_row_sleeves');
 
 		switch ($columnId) {
-			case -1: // row ID
+			case Column::TYPE_META_ID:
 				$qb2->where($this->getSqlOperator($operator, $qb, 'id', $value, IQueryBuilder::PARAM_INT));
 				break;
-			case -2: // created by
+			case Column::TYPE_META_CREATED:
 				$qb2->where($this->getSqlOperator($operator, $qb, 'created_by', $value, IQueryBuilder::PARAM_STR));
 				break;
-			case -3: // created at
+			case Column::TYPE_META_CREATED_AT:
 				$qb2->where($this->getSqlOperator($operator, $qb, 'created_at', $value, IQueryBuilder::PARAM_DATE));
 				break;
-			case -4: // last edit by
+			case Column::TYPE_META_UPDATED:
 				$qb2->where($this->getSqlOperator($operator, $qb, 'last_edit_by', $value, IQueryBuilder::PARAM_STR));
 				break;
-			case -5: // last edit at
+			case Column::TYPE_META_UPDATED_AT:
 				$qb2->where($this->getSqlOperator($operator, $qb, 'last_edit_at', $value, IQueryBuilder::PARAM_DATE));
 				break;
 		}