Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure default values show as filled #1176

Merged
merged 2 commits into from
Aug 6, 2024
Merged

fix: ensure default values show as filled #1176

merged 2 commits into from
Aug 6, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jul 1, 2024

fixes #993

@enjeck enjeck added the 3. to review Waiting for reviews label Jul 1, 2024
@enjeck enjeck requested review from blizzz and elzody July 1, 2024 19:23
@enjeck enjeck self-assigned this Jul 1, 2024
@elzody
Copy link
Contributor

elzody commented Jul 2, 2024

Seems reasonable, just a weird Cypress error. I am assuming it is related since it's affecting the column-number.cy.js test, but have not looked into it.

@juliushaertl
Copy link
Member

I am wondering if instead of filling the default value then we should rather use the placeholder attribute and andjudt the check to allow empty fields for values that have a default? That way a default value would also adapt if changed on the table level.

@enjeck
Copy link
Contributor Author

enjeck commented Jul 9, 2024

I am wondering if instead of filling the default value then we should rather use the placeholder attribute and andjudt the check to allow empty fields for values that have a default? That way a default value would also adapt if changed on the table level.

I just noticed that this problem also affects other column types, not just the number column. Would look into making this approach more generic

@enjeck enjeck added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 9, 2024
@enjeck enjeck force-pushed the fix/993 branch 3 times, most recently from 1225937 to cc065f2 Compare July 17, 2024 15:40
@enjeck enjeck changed the title fix: ensure numeric default value shows as filled fix: ensure default values show as filled Aug 1, 2024
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@juliushaertl juliushaertl merged commit 852bfd0 into main Aug 6, 2024
46 checks passed
@juliushaertl juliushaertl deleted the fix/993 branch August 6, 2024 19:15
@juliushaertl
Copy link
Member

Don't be too hesitant to click the merge button if it is green 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Leaving default value qualifies as not filled
3 participants