-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): align icon to center #1219
fix(files): align icon to center #1219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think there should be more space between the Title input field and the "Description" label in the Create/Edit table modal, but if it didn't come up in the design review, I guess it's not bad
thanks @enjeck!
I haven't seen it in requirement list |
Would still be nice for general polishing to make things look well aligned but we can probably tackle that when migrating to NcDialog, as a separate issue or right away in here, however you prefer @JuliaKirschenheuter |
for sure i can make more space between the Title input field and the "Description" label! @enjeck should we probably use |
From the docs here https://nextcloud-vue-components.netlify.app/#/Components/NcFields?id=nctextfield, we can't use it? Or maybe I misunderstand. Also, if we want to change it here, would be nice to change it everywhere else for consistency |
No sure if i understood you correct, i mean something like this: instead of: |
Probably the docs are a bit confusing, this message only referrs to NcInputField, NcTextField is fine to be used (scroll further down for the actual docs of that) |
c8ce422
to
dca0718
Compare
done ;) |
dca0718
to
1a0cc12
Compare
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
1a0cc12
to
932a048
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes #1214