Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): align icon to center #1219

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jul 19, 2024

Fixes #1214

Before After
Screenshot from 2024-07-18 11-15-11 Screenshot from 2024-07-26 10-48-10
Screenshot from 2024-07-18 11-15-31 Screenshot from 2024-07-26 10-47-57

Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think there should be more space between the Title input field and the "Description" label in the Create/Edit table modal, but if it didn't come up in the design review, I guess it's not bad

@JuliaKirschenheuter
Copy link
Contributor Author

thanks @enjeck!

I think there should be more space between the Title input field and the "Description" label in the Create/Edit table modal

I haven't seen it in requirement list

@juliusknorr
Copy link
Member

thanks @enjeck!

I think there should be more space between the Title input field and the "Description" label in the Create/Edit table modal

I haven't seen it in requirement list

Would still be nice for general polishing to make things look well aligned but we can probably tackle that when migrating to NcDialog, as a separate issue or right away in here, however you prefer @JuliaKirschenheuter

@JuliaKirschenheuter
Copy link
Contributor Author

for sure i can make more space between the Title input field and the "Description" label! @enjeck should we probably use nctextfield instead custom input field?

@enjeck
Copy link
Contributor

enjeck commented Jul 24, 2024

nctextfield

From the docs here https://nextcloud-vue-components.netlify.app/#/Components/NcFields?id=nctextfield, we can't use it? Or maybe I misunderstand.

Also, if we want to change it here, would be nice to change it everywhere else for consistency

@JuliaKirschenheuter
Copy link
Contributor Author

From the docs here https://nextcloud-vue-components.netlify.app/#/Components/NcFields?id=nctextfield, we can't use it? Or maybe I misunderstand.

No sure if i understood you correct, i mean something like this:

Screenshot from 2024-07-24 18-54-32

instead of:

Screenshot from 2024-07-24 18-56-15

@juliusknorr
Copy link
Member

nctextfield

From the docs here nextcloud-vue-components.netlify.app#/Components/NcFields?id=nctextfield, we can't use it? Or maybe I misunderstand.

Also, if we want to change it here, would be nice to change it everywhere else for consistency

Probably the docs are a bit confusing, this message only referrs to NcInputField, NcTextField is fine to be used (scroll further down for the actual docs of that)

Screenshot 2024-07-25 at 16 03 51

@JuliaKirschenheuter
Copy link
Contributor Author

I think there should be more space between the Title input field and the "Description" label in the Create/Edit table

done ;)

@JuliaKirschenheuter JuliaKirschenheuter added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 26, 2024
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the bugfix-1214-icon-picker-is-misaligned branch from dca0718 to 1a0cc12 Compare July 26, 2024 08:51
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the bugfix-1214-icon-picker-is-misaligned branch from 1a0cc12 to 932a048 Compare July 26, 2024 09:24
@JuliaKirschenheuter JuliaKirschenheuter merged commit a617215 into main Jul 26, 2024
46 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the bugfix-1214-icon-picker-is-misaligned branch July 26, 2024 09:41
@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 26, 2024
Copy link
Contributor

github-actions bot commented Aug 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"New table dialog", "Applications create dialog": Icon picker is misaligned
3 participants