Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make user listing in table more consistent by using NcUserBubble #1254

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: Make user listing in table more consistent by using NcUserBubble #1254

merged 2 commits into from
Aug 2, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 1, 2024 •
edited
Loading

  • Use the displayname if present
  • Use NcUserBubble instead of custom styling
Screenshot 2024-08-01 at 17 20 15

With user status we render it larger:
Screenshot 2024-08-01 at 17 21 09

@juliusknorr juliusknorr requested a review from enjeck August 1, 2024 15:20
@juliusknorr juliusknorr force-pushed the fix/user-bubble branch 2 times, most recently from 4328a30 to 271f6d2 Compare August 2, 2024 12:15
@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Aug 2, 2024
@juliusknorr juliusknorr added this to the v0.8.0 milestone Aug 2, 2024
@juliusknorr
fix: Make user listing in table more consistent by using NcUserBubble
adc7b57 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Properly show displayname and status depending on type
546c9f4 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit 6621729 into main Aug 2, 2024
46 checks passed
@juliusknorr juliusknorr deleted the fix/user-bubble branch August 2, 2024 14:53
@enjeck
Copy link
Contributor

enjeck commented Aug 28, 2024

@juliushaertl Just noticed this change now. Not exactly sure why this is better? The "problem" with using NcUserBubble instead of NcAvatar is that we no longer have the option to click on an item, see additional information and directly click on the link to visit the user's profile. Having this is very convenient, imo.
Screenshot from 2024-08-28 19-02-06

@enjeck enjeck mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@blizzz blizzz blizzz approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@enjeck enjeck Awaiting requested review from enjeck

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @enjeck @AndyScherzinger @blizzz @JuliaKirschenheuter