fix: reduce arguments for column creation function #1281
Merged
+433
−551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luka-nextcloud
commented
Aug 8, 2024
luka-nextcloud
commented
- Resolves: Refactor column creation function #1236
enjeck
reviewed
Aug 18, 2024
luka-nextcloud
force-pushed
the
fix/column-create-function
branch
from
3ee6977
to
93d68c3
Compare
There was a problem hiding this comment.
Left some comments but would also appreciate some feedback from @blizzz on how to approach this
luka-nextcloud
force-pushed
the
fix/column-create-function
branch
from
93d68c3
to
fbd8615
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
fix/column-create-function
branch
from
fbd8615
to
331d0b6
Compare
blizzz
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.