Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use different app menu selectors #1292

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: use different app menu selectors #1292

merged 1 commit into from
Aug 14, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Aug 14, 2024

The app menu selector changed, so we need these updates to when the table or application is active

Also added a check to avoid unnecessary work when editing rows

Right now, all this is very hacky. Not sure if there's a better solution. Having data-app-id made this more robust, but that isn't available anymore

This gets rid of the console errors

NavigationTableItem.vue:134 [Vue warn]: Error in callback for watcher "$route": "TypeError: Cannot read properties of null (reading 'classList')"

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck enjeck self-assigned this Aug 14, 2024
@enjeck enjeck added the bug Something isn't working label Aug 14, 2024
@juliusknorr juliusknorr merged commit b910772 into main Aug 14, 2024
47 checks passed
@juliusknorr juliusknorr deleted the fix-app-menu branch August 14, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants