-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add UI elements to modify navigation display #1295
base: enh/1177/enable-nav-display-logic
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enjeck nice!
So unless I misunderstand something, the settings seem can be simplified. As admins are also just users, they can use the navigation preference like everyone else.
The main settings should only say:
[ ] Show in app list
As a single checkbox, no subheading needed. It can have a color-text-maxcontrast sentence below saying "This can be overridden by a per-account preference."
For the left navigation entry, same wording and setting
[ ] Show in app list
@jancborchardt This is not possible now, from what I see. There's no option for an owner to modify just their visibility, without affecting share recipients. And I'm not sure why it's not supported. I'll clarify at #1193 and see what can be changed |
ac42f69
to
ccf873b
Compare
e0b033f
to
215ca74
Compare
It was temporarily disabled and shown by default as we did not have web UI controls to configure it. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
ccf873b
to
8075a22
Compare
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
52553e6
to
37e8272
Compare
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
So here are the challenges we've faced so far: Since navigation display setting is tied to shares, there is an additional share from the owner of an application to themselves. From discussions with @blizzz, we believe this is not good practice, but it's what it takes to get a better UX at the moment. The problem we have encountered now is that for owners of an application, the modifying the display does not work properly like with the sharees. So the plan now is:
|
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
… column Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
8075a22
to
0edd48a
Compare
0edd48a
to
cd00c05
Compare
Part of #1177 and #1193
Todo