Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open row edit modal on initial load #1312

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: Open row edit modal on initial load #1312

merged 1 commit into from
Aug 22, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 22, 2024

When opening a link like https://nextcloud.local/index.php/apps/tables/#/table/1/row/1 we should open the modal to edit the row directly. This was broken before as the element (table or view was not passed along while the modal component requires it).

Can also be reproduced by editing a row and just reloading the browser.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Aug 22, 2024
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍

@juliusknorr juliusknorr merged commit c909f65 into main Aug 22, 2024
47 checks passed
@juliusknorr juliusknorr deleted the fix/row-open branch August 22, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants