Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Rows): switch front-end to use Row OCS API #1351

Merged
merged 10 commits into from
Sep 12, 2024
Merged

refactor(Rows): switch front-end to use Row OCS API #1351

merged 10 commits into from
Sep 12, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Sep 12, 2024

includes

  • a fix of the RowDataInput – has to be iterable, otherwise values were stored empty 🙈
  • and a fix to accept selection-type values with the rows ocs endpoint
  • and extended tests

@blizzz
test(behat): add tests on adding columns to views
3eeb110 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fix(Controller): respond with 400 on InvalidArgumentExceptions
94da27a 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fix(Model): RowDataInput must be iterable
a83dbcd 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
test(behat): fix view had no columns assigned
011d3c4 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
test(behat): check that returned created row matches input values
0844c6e 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
refactor(Rows): switch front-end to use Row OCS API
fcbba69 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
refactor(Controller): increase use of Permission middleware
483aace 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fix: create rows with selection cols via RowOCSController
20d3124 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
build(openapi): ts types
d3436e8 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews labels Sep 12, 2024
@blizzz blizzz added this to the v0.8.0 milestone Sep 12, 2024
@blizzz
style(js): satisfy stylelint
b94be07 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz merged commit 52846ad into main Sep 12, 2024
61 checks passed
@blizzz blizzz deleted the fix/use-ocs-row-create branch September 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@enjeck enjeck Awaiting requested review from enjeck

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@blizzz @juliusknorr