Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use actual providerId in link rows #1443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: use actual providerId in link rows #1443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Service/ColumnTypes/TextLinkBusiness.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function parseValue($value, ?Column $column = null): string {
return json_encode(json_encode([
'title' => $data['title'] ?? $data['resourceUrl'],
'value' => $data['resourceUrl'],
'providerId' => 'url',
'providerId' => isset($data['providerId']) ? $data['providerId'] : 'url',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if there's a reason why 'url' was hardcoded here instead of just using the providerId like this 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originates from #779

Does line 30 needs treatment as well?

Shorthand should also do:

Suggested change
'providerId' => isset($data['providerId']) ? $data['providerId'] : 'url',
'providerId' => $data['providerId'] ?? 'url',

]));
}
// at least title and resUrl have to be set
Expand Down
Loading