refactor: OO approach for better handling of columns and more #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't had a full review yet, but looks like a great refactoring :) |
|
/rebase |
|
@Hephi2 Can we update this and merge soon as new base for the FE...?! |
|
Sure, I'll do that |
Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Hephi2
force-pushed
the
refactor-#337-refactor-oop
branch
from
6fc746f
to
0dff4a9
Compare
…and incompatible filters and refactors a little further Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Hephi2
force-pushed
the
refactor-#337-refactor-oop
branch
from
1636fc2
to
6a74a24
Compare
datenangebot
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Wow, what a great refactoring. Many thanks! 👏
-
I put some comments below, maybe we can simplify some things. 🙇🏻♂️
-
What do you think about a dev-documentation for the wiki with the topic about
How to create or adjust a (new) column type. This could give us a documentation at which points we can/have to adjust the business logic for a column and on the other side where we find the framework that renders and make some magic FE stuff for columns.
Btw: It's so great to see that the CI is green with all that changes. 🙄
…ly by column name Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
datenangebot
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337