-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid error on CORS requests #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your pull request. Your change mages sense, though the fallback to empty string is not required and we should probably just keep the null value then. Could you adjust that? Then we can get this merged for the next release
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Commit suggestion from @juliushaertl Co-authored-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Marius H. <derlohlgianer@gmail.com>
Make `Api1Controller->userId` nullable to supress errors/warnings when assigning `null` to it Signed-off-by: Marius H. <derlohlgianer@gmail.com>
Made constructor parameter $userId of type
?string
(= be optional)If no userId is passed (aka. is null),
$this->userId is set to an empty string to not cause any problems or errors.
See #465 for more info