Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error on CORS requests #466

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Avoid error on CORS requests #466

merged 3 commits into from
Aug 28, 2023

Conversation

Logianer
Copy link
Contributor

Made constructor parameter $userId of type ?string (= be optional)
If no userId is passed (aka. is null),
$this->userId is set to an empty string to not cause any problems or errors.

See #465 for more info

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your pull request. Your change mages sense, though the fallback to empty string is not required and we should probably just keep the null value then. Could you adjust that? Then we can get this merged for the next release

lib/Controller/Api1Controller.php Outdated Show resolved Hide resolved
@juliusknorr juliusknorr changed the title fix for #465 Avoid error on CORS requests Aug 14, 2023
@juliusknorr juliusknorr added bug Something isn't working 2. developing Work in progress labels Aug 14, 2023
@juliusknorr juliusknorr added this to the v0.6.0 milestone Aug 14, 2023
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@datenangebot
Copy link
Collaborator

datenangebot commented Aug 28, 2023

Makes sense. But null is better than '' because an empty string is sometimes used as 'super admin' with additional permissions.

Failing test belongs to #453.
Will merge.

@Logianer Many thanks.

Logianer and others added 3 commits August 28, 2023 09:55
Made constructor parameter $userId of type `?string`
(= be optional)
If no userId is passed (aka. is null),
$this->userId is set to an empty string to not cause any problems or errors.

Signed-off-by: Marius H. <derlohlgianer@gmail.com>
Commit suggestion from @juliushaertl

Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Marius H. <derlohlgianer@gmail.com>
Make `Api1Controller->userId` nullable to supress errors/warnings when assigning `null` to it

Signed-off-by: Marius H. <derlohlgianer@gmail.com>
@datenangebot datenangebot merged commit ee22b29 into nextcloud:main Aug 28, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants