-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @nextcloud/vue to v8 #647
Conversation
8767be2
to
9198be9
Compare
9198be9
to
1ec12a2
Compare
34a9e33
to
b070c37
Compare
b070c37
to
8b49a45
Compare
8b49a45
to
f2df6eb
Compare
f2df6eb
to
65a4b70
Compare
7293606
to
127a287
Compare
a8fe263
to
82829db
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
@juliushaertl I turned off auto-merge here. Lots of changes, want a second look to make sure it's all good |
src/pages/Startpage.vue
Outdated
|
||
<style scoped> | ||
|
||
:deep(.empty-content) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering a bit why we need the :deep()
here but not in the other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we're targeting a child element (I think, not a 100% sure). It doesn't work without this tho
src/shared/components/ncTable/partials/rowTypePartials/DatetimeDateForm.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks for checking that so quickly. I left two nitpicks and one additional migration that we should do to the native date time picker component
e85ecdc
to
19b6df9
Compare
if (this.value !== null && this.value !== 'none') { | ||
return Moment(this.value, 'HH:mm').toDate() | ||
} else if (this.value === null && this.column.datetimeDefault === 'now') { | ||
const dt = Moment() | ||
this.$emit('update:value', dt.format('HH:mm')) | ||
return dt.toDate() | ||
} else { | ||
return null | ||
return new Date() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this because otherwise, get the error message "TypeError: Cannot destructure property 'yyyy' of 'this.getReadableDate(...)' as it is undefined."
, originating from the NcDateTimePickerNative component. The downside of this is it initializes the time to the current time. Which defeats the purpose of having a separate checkbox for Set now as default
.
Maybe there's a better way to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a good way for this with the native picker as it does not allow to select an empty value. Maybe we need to change the UI there to have a button to add a date which then shows the selector (and prefills with the current date) and have a button next to it to remove it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, your approach seems reasonable as I tested and we already have an option to reset with the first branch in line 41
8fe2dd7
to
361c96e
Compare
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
361c96e
to
41969f4
Compare
This PR contains the following updates:
^7.12.7
->^8.6.1
Release Notes
nextcloud-libraries/nextcloud-vue (@nextcloud/vue)
v8.6.1
Compare Source
Full Changelog
🐛 Fixed bugs
Other Changes
v8.6.0
Compare Source
Full Changelog
🚀 Enhancements
🐛 Fixed bugs
Other Changes
v8.5.1
Compare Source
Full Changelog
🐛 Fixed bugs
Other Changes
v8.5.0
Compare Source
Full Changelog
🚀 Enhancements
NcSelect
to body by @raimund-schluessler in https://github.com/nextcloud-libraries/nextcloud-vue/pull/5017NcRichText
) add support of GFM (extended markdown) by @Antreesy in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4365🐛 Fixed bugs
showWeekNumber
is set by @susnux in https://github.com/nextcloud-libraries/nextcloud-vue/pull/5045a
as tag for router-link by @raimund-schluessler in https://github.com/nextcloud-libraries/nextcloud-vue/pull/5091tab
,tablist
andaria-selected
roles from navigation by @JuliaKirschenheuter in https://github.com/nextcloud-libraries/nextcloud-vue/pull/5075Other Changes
v8.4.0
Compare Source
Full Changelog
Notes
isMobile
andisFullscreen
mixins are now deprecated, useuseIsMobile
anduseIsFullscreen
composables instead🚀 Enhancements
aria-label
by @susnux in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4903🐛 Fixed bugs
active
prop by @raimund-schluessler in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4989aria-expanded="false"
when menu is closed instead of removing it by @ShGKme in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4946TextArea
styles withTextField
styles by @JuliaKirschenheuter in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4971NcRichContenteditable
by @JuliaKirschenheuter in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4975Other Changes
v8.3.0
Compare Source
Full Changelog
🚀 Enhancements
🐛 Fixed bugs
main-text
for accessibility #4885 (susnux)v-tooltip
with nativetitle
#4888 (ShGKme)Other Changes
v8.2.0
Compare Source
Full Changelog
🚀 Enhancements
🐛 Fixed bugs
unregisterSection
should remove the section instead of remove all other #4798 (susnux)min-height
over sidebar and settings … #4825 (JuliaKirschenheuter)min-height
over sidebar and settings dialog on small screens #4836 (JuliaKirschenheuter)Other Changes
v8.1.0
Compare Source
Full Changelog
🚀 Enhancements
useIsMobile
anduseIsFullscreen
composables #4761 (@ShGKme)🐛 Fixed bugs
Other Changes
v8.0.1
Compare Source
Full Changelog
🐛 Fixed bugs
aria-label
of close button by @susnux in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4778t
method by @ShGKme in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4790Other Changes
v8.0.0
Compare Source
Full Changelog
💥 Breaking changes
NcMultiselect
andNcMultiselectTags
components were removed #4281 (susnux)NcSelect
andNcSelectTags
components insteadNcPopoverMenu
component was removed #4081 (raimund-schluessler)NcActions
component insteadNcAppNavigationCounter
component was removed #4096 (raimund-schluessler)NcCounterBubble
component insteadexcludeClickOutsideClasses
property was removed fromclickOutsideOptions
#4088 (raimund-schluessler)excludeClickOutsideSelectors
property, which takes an array of css selectors, insteadlabel
property ofNcAutoCompleteResult
was renamed totitle
#4222 (susnux)title
property was removed, every occurrence oftitle
was renamed toname
#4106 (raimund-schluessler), #4052 (raimund-schluessler)label
property was renamed toname
forNcMentionBubble
name
propery is now required forNcActions*
,NcAppNavigationItem
andNcBreadcrumb*
install
entry point and replace it with an Vue Plugin #4349 (susnux)NcInputField
: ThelabelVisible
property was removed for accessibility it is required to always show a label.You can still use the
labelOutside
property to remove the inner label from the component.Datetime
toDateTime
in component names #4560 (susnux)🚀 Enhancements
NcAvatar
to useNcActions
#4017 (raimund-schluessler)NcInputField
on border #4394 (susnux)NcRichContenteditable
) - add different output appearance in examples #4485 (Antreesy)@nextcloud/dialogs
) #4550 (susnux)active
property to set active state & usearia-current
#4716 (susnux🐛 Fixed bugs
NcMultiselect
toNcSelect
#4120 (susnux)NcMultiselect
toNcSelect
#4247 (julien-nc)@
in username #4222 (susnux)aria-expanded
attribute to settings accordion button #4109 (Fenn-CS)pressed
state for stateful buttons #4344 (susnux)NcListItem
) - remove empty wrapper for additional elements from DOM if not needed #4438 (Antreesy)exports
field of package used deprecated syntax #4437 (susnux)NcListItem
) don't force blur action menu on tab #4458 (Antreesy)NcRichText
) - keep newlines in rendered Markdown #4461 (Antreesy)NcRichText
) - don't populate a first newline to properly parse blockqoute tags #4470 (Antreesy)NcCheckboxRadioSwitch
required
prop and input position fix #4488 (skjnldsv)<tag>
-like content when parsing markdown #4486 (Antreesy)native
for selected emoji [Configuration
📅 Schedule: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.