Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @nextcloud/vue to v8 #647

Merged
merged 11 commits into from
Feb 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 4, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@nextcloud/vue ^7.12.7 -> ^8.6.1 age adoption passing confidence

Release Notes

nextcloud-libraries/nextcloud-vue (@​nextcloud/vue)

v8.6.1

Compare Source

Full Changelog

🐛 Fixed bugs
Other Changes
  • Updated translations
  • fix(CI): Adjust npm-publish to work with GPR #​5183 (susnux)
  • chore(CHANGELOG): Add missing entry for 8.6.0 release #​5192 (susnux)

v8.6.0

Compare Source

Full Changelog

🚀 Enhancements
🐛 Fixed bugs
Other Changes

v8.5.1

Compare Source

Full Changelog

🐛 Fixed bugs
  • fix(NcPopover): a11y attrs provide-inject reactivity #​5142 (ShGKme)
  • fix(NcCheckboxRadioSwitch): On button style align the text vertically #​5151 (susnux)
  • fix: removed groupings in timezone picker #​5130 (emoral435)
  • fix(fields): adjust label line-height #​5133 (ShGKme)
  • fix(header): width regression fixed #​5129 (emoral435)
  • fix(NcCheckboxRadioSwitch): Make sure to include current value in checked array #​5150 (susnux)
  • fix: Ensure no double scrollbars for NcDialog and NcAppNavigationSettings #​5139 (susnux)
  • fix(NcAvatar): Remove span wrapper button semantics in favour of internal button components #​5131 (Pytal)
Other Changes
  • Updated translation
  • chore: Fix missing PR from changelog #​5125 (Pytal)
  • chore: Migrate cypress config to vite instead of webpack #​4961 (susnux)
  • chore(styleguide): set line-height from server styles #​5132 (ShGKme)

v8.5.0

Compare Source

Full Changelog

🚀 Enhancements
🐛 Fixed bugs
Other Changes

v8.4.0

Compare Source

Full Changelog

Notes
  • NcRichContenteditable: new visual label feature might break layout if you have custom contenteditable styles
  • isMobile and isFullscreen mixins are now deprecated, use useIsMobile and useIsFullscreen composables instead
🚀 Enhancements
🐛 Fixed bugs
Other Changes

v8.3.0

Compare Source

Full Changelog

🚀 Enhancements
  • feat(NcInputField): add optional pill form appearance to the component #​4876 (Antreesy)
🐛 Fixed bugs
  • fix(NcCheckboxContent): Make sure text can wrap #​4862 (susnux)
  • fix(NcAppNavigation): make toggle button not the first element for focus-trap #​4864 (Antreesy)
  • fix(NcAppNavigation): closed on mobile initially #​4869 (ShGKme)
  • fix(NcAppSettingsDialog): Remove navigation instead of hiding and fix styles #​4865 (susnux)
  • Remove server styles from action menu #​4875 (marcoambrosini)
  • fix(NcCheckboxRadioSwitch): visually hidden input position #​4882 (ShGKme)
  • fix(NcDialog): Add slighly more padding on the bottom and fix example button order #​4881 (susnux)
  • docs(NcAppNavigation): Add docs for slots and remove private components from styleguide #​4883 (susnux)
  • fix(NcAppNavigationCaption): Make color main-text for accessibility #​4885 (susnux)
  • fix(NcColorPicker): correct aria-label #​4889 (ShGKme)
  • fix(NcActions): typo in aria-haspopup #​4887 (ShGKme)
  • fix(NcAppNavigation): replace custom v-tooltip with native title #​4888 (ShGKme)
Other Changes
  • chore(lint): use valid JSDoc for literal type union #​4989 (ShGKme)
  • Update translations

v8.2.0

Compare Source

Full Changelog

🚀 Enhancements
🐛 Fixed bugs
Other Changes
  • Update translations

v8.1.0

Compare Source

Full Changelog

🚀 Enhancements
🐛 Fixed bugs
Other Changes
  • Update translations

v8.0.1

Compare Source

Full Changelog

🐛 Fixed bugs
Other Changes

v8.0.0

Compare Source

Full Changelog

💥 Breaking changes
  • Update node engines to next LTS (node 20 / npm 9)
  • The deprecated NcMultiselect and NcMultiselectTags components were removed #​4281 (susnux)
    • Migration: Use the NcSelect and NcSelectTags components instead
  • The deprecated NcPopoverMenu component was removed #​4081 (raimund-schluessler)
    • Migration: Use the NcActions component instead
  • The deprecated NcAppNavigationCounter component was removed #​4096 (raimund-schluessler)
    • Migration: Use the NcCounterBubble component instead
  • The deprecated excludeClickOutsideClasses property was removed from clickOutsideOptions #​4088 (raimund-schluessler)
    • Migration: Use the excludeClickOutsideSelectors property, which takes an array of css selectors, instead
  • The label property of NcAutoCompleteResult was renamed to title #​4222 (susnux)
  • The deprecated title property was removed, every occurrence of title was renamed to name #​4106 (raimund-schluessler), #​4052 (raimund-schluessler)
    • label property was renamed to name for NcMentionBubble
    • name propery is now required for NcActions*, NcAppNavigationItem and NcBreadcrumb*
    • See linked pull request for full migration guide
  • chore: Drop install entry point and replace it with an Vue Plugin #​4349 (susnux)
  • NcInputField: The labelVisible property was removed for accessibility it is required to always show a label.
    You can still use the labelOutside property to remove the inner label from the component.
  • feat(NcEmptyContent)!: make empty content centered by default instead of 20vh margin #​4506 (ShGKme)
  • chore!: Rename Datetime to DateTime in component names #​4560 (susnux)
  • feat(NcIconSvgWrapper)!: remove ID from svg #​4607 (ShGKme)
🚀 Enhancements
  • feat(NcAppSettingsDialog): Allow to add icons to the navigation sections #​4745 (susnux)
  • feat(NcButton): Allow to format text of button #​4367 (susnux)
  • enh(NcDatetime): New component for displaying timestamps as time relative from now #​4219 (susnux)
  • feat(NcInputField): Append custom aria-describedby to input field #​4225 (Pytal)
  • feat(NcNoteCard): Add new 'info' version to display informational messaged #​4063 (moan0s)
  • feat(NcEmptyContent): Add slot for description #​3895 (susnux)
  • feat(NcActions): Improve readability of action menu entries #​4049 (Pytal)
  • feat(NcReferencePickerModal): Allow setting modal size when registering a custom picker component #​3866 (julien-nc)
  • feat: Migrate NcAvatar to use NcActions #​4017 (raimund-schluessler)
  • feat(a11y): Export a11y activation util #​4166 (Pytal)
  • NcButton: Add alignment property to change icon and text ordering #​4366 (susnux)
  • Add accessible label to textarea #​4448 (Pytal)
  • Remove border from sidebar tabs #​4449 (marcoambrosini)
  • Make smart picker modal close button tertiary #​4441 (julien-nc)
  • Add menuitem role to action link #​4436 (Pytal)
  • feat(NcModal): Allow to configure if the modal is closed when clicked outside #​4454 (susnux)
  • Feature: Add visible inner label for NcInputField on border #​4394 (susnux)
  • Bring back label outside of the input for NcActionInput #​4484 (juliushaertl)
  • feat(NcRichContenteditable) - add different output appearance in examples #​4485 (Antreesy)
  • perf(NcEmojiPicker): decrease mounting time and memory by moving large constants initialization and storing out from instance's reactive data #​4479 (ShGKme)
  • enh(NcAppNavigationCaption): Forward listeners #​4494 (Pytal)
  • enh(a11y): Use button as header menu trigger #​4481 (Pytal)
  • enh(a11y): Add nav to header menu #​4487 (Pytal)
  • feat(NcIconSvgWrapper): allow to render raw svg paths #​4643 (raimund-schluessler)
  • feat(NcDialog): New component (moved from @nextcloud/dialogs) #​4550 (susnux)
  • feat(NcSelect): Allow to filter users by email notation #​4653 (susnux)
  • enh(NcAppSidebarTabs): Make tab navigation accessible #​4663 (Pytal)
  • Add the resource type on RelatedResourcesPanel #​4662 (GretaD)
  • feat(NcTextArea): implement new textarea component #​4605 (st3iny)
  • Add header prop to NcRelatedResourcesPanel #​4703 (GretaD
  • feat(NcAppNavigationItem): Add active property to set active state & use aria-current #​4716 (susnux
  • feat(NcActionButton): support menu styling #​4724 (skjnldsv
  • Made description dynamic on related resources #​4729 (GretaD
  • fix(NcTimezonePicker): Allow to set ID of inner select component #​4734 (susnux
  • Allow preventing link insertion in RichContentEditable #​3890 (julien-nc
🐛 Fixed bugs
  • fix(NcSettingsSelectGroup): Migrate from deprecated NcMultiselect to NcSelect #​4120 (susnux)
  • fix(NcRichtext): Migrate from deprecated NcMultiselect to NcSelect #​4247 (julien-nc)
  • fix(NcAppNavigation): Prevent tabbing into closed navigation #​3114 (PVince81)
  • fix(NcDatetimePicker): Make sure all l10n strings are extracted #​4272 (susnux)
  • fix(NcAppNavigationCaption): Align actions with other navigation action #​4220 (susnux)
  • fix(NcInputField): Increase input field helper text contrast #​4188 (Pytal)
  • fix(NcSelect): Hide clear and deselect button when disabled #​4212 (Pytal)
  • fix(NcSelect): Fix disabled colors to distinguish the disabled state from the regular state #​4217 (Pytal)
  • fix(NcProviderList): Add padding around provider list #​4175 (juliushaertl)
  • fix(NcModal): Fix focus-trap fallback if content is empty #​4266 (skjnldsv)
  • fix(NcActionInput): Show trailing button even for empty input #​4251 (susnux)
  • fix(NcRichContenteditable): Fix mentioning users with @ in username #​4222 (susnux)
  • fix(NcProgressBar): Fix design on chromium browsers #​4238 (szaimon)
  • fix(NcReferencePicker): Fix padding in the any link preview component #​4248 (julien-nc)
  • fix(NcModal): Set background and text color #​4221 (susnux)
  • fix(NcSelect): Keep dropdown open while loading #​4209 (Pytal)
  • fix(NcCheckboxRadioSwitch): Add focus-visible style #​4176 (Fenn-CS)
  • fix(NcAppNavigationSettings): Add aria-expanded attribute to settings accordion button #​4109 (Fenn-CS)
  • fix(clickOutsideOptions): Fix handling of ignored css selectors #​4046 (susnux)
  • fix(NcResource): Fix item alignment in the right sidebar #​4121 (Pytal)
  • fix(NcAppSidebarTabs): Fix rendering tabs with CSS icon #​4111 (ShGKme)
  • fix(NcAppNavigationItem): Left panel dropdown improvement #​4103 (Jerome-Herbinet)
  • fix(NcSettingsSection): Add target blank and no ref info #​4099 (Rello)
  • fix: Use the color-primary-element* variables in components #​4067 (szaimon)
  • fix(NcListItem): Fix wrong bold class #​4083 (julien-nc)
  • fix(NcSelect): Fix disabled state of NcSelect with dark mode #​4079 (nickvergessen)
  • fix(NcSelect): Action input usage #​4066 (Pytal)
  • fix(NcRichContenteditable): Fix avatar overlayed with empty space when offline #​4043 (nickvergessen)
  • fix(l10n): Add language mappings like server does so gettext uses the same locale #​4412 (susnux)
  • fix(l10n): Remove quoting character #​4396 (rakekniven)
  • fix(NcModal): prev/next color and sizing fix #​4368 (skjnldsv)
  • fix(NcListItem) - define a single place for NcActions to render #​4356 (Antreesy)
  • fix(NcModal): Close button should be visible even if modal content is scrolled #​4350 (susnux)
  • fix(NcButton): Improve alignment documentation to show all variants. #​4392 (susnux)
  • try to fix header size on mobile #​4420 (szaimen)
  • fix(NcButton): correctly emit click event #​4398 (raimund-schluessler)
  • feat(NcButton): Add pressed state for stateful buttons #​4344 (susnux)
  • NcCheckboxRadioSwitch - adjust border color #​4427 (szaimen)
  • fix(NcRichContenteditable): Add aria-placeholder #​4407 (ShGKme)
  • fix(NcModal): Fix modal focus trap with additional elements and arrow navigation #​4406 (ShGKme)
  • Fix contrast for selected item #​4434 (JuliaKirschenheuter)
  • fix(NcListItem) - remove empty wrapper for additional elements from DOM if not needed #​4438 (Antreesy)
  • fix: exports field of package used deprecated syntax #​4437 (susnux)
  • Prevent accessible name conflicts on action menu #​4447 (Pytal)
  • fix: adjust active element visibility in nclistitem #​4158 (szaimen)
  • fix: adjust breadcrumbs component #​4416 (raimund-schluessler)
  • fix(NcSelect): Use named export of VueSelect to prevent issues when imported in ESM projects #​4451 (susnux)
  • fix(NcCheckboxRadioSwitch): If no text is provided the element should be a circle #​4453 (susnux)
  • fix(NcListItem) don't force blur action menu on tab #​4458 (Antreesy)
  • fix(NcRichText) - keep newlines in rendered Markdown #​4461 (Antreesy)
  • fix(NcRichText) - don't populate a first newline to properly parse blockqoute tags #​4470 (Antreesy)
  • fix(a11y): Remove nav and radios in sidebar tabs #​4456 (Pytal)
  • fix(NcSelect): Do not add border to single select option #​4475 (Pytal)
  • feat and fix: NcCheckboxRadioSwitch required prop and input position fix #​4488 (skjnldsv)
  • Align NcCheckboxRadioSwitch labels #​4490 (raimund-schluessler)
  • fix(EmptyContent): svg max size #​4496 (skjnldsv)
  • fix(NcRichContenteditable): make the default placeholder short #​4408 (ShGKme)
  • Stop propagation of keyboard navigation in a number of components #​4501 (ShGKme)
  • fix(NcRichText) - don't strip <tag>-like content when parsing markdown #​4486 (Antreesy)
  • fix(NcAppNavigation): Make the navigation toggle accessible again when closed #​4546 (susnux)
  • fix: Replace sanitize-svg with dompurify #​4557 (raimund-schluessler)
  • fix(NcEmojiPicker): Do not set padding for the search input label #​4577 (susnux)
  • fix(NcEmojiPicker): Set type to native for selected emoji [

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Nov 4, 2023
@renovate renovate bot requested review from a team, juliusknorr and office-team-bot and removed request for a team November 4, 2023 01:59
@renovate renovate bot changed the title fix(deps): update dependency @nextcloud/vue to v8 fix(deps): update dependency @nextcloud/vue to v8 - autoclosed Nov 7, 2023
@renovate renovate bot closed this Nov 7, 2023
@renovate renovate bot deleted the renovate/nextcloud-vue-8.x branch November 7, 2023 11:34
@renovate renovate bot changed the title fix(deps): update dependency @nextcloud/vue to v8 - autoclosed fix(deps): update dependency @nextcloud/vue to v8 Nov 8, 2023
@renovate renovate bot reopened this Nov 8, 2023
@renovate renovate bot restored the renovate/nextcloud-vue-8.x branch November 8, 2023 16:05
@renovate renovate bot force-pushed the renovate/nextcloud-vue-8.x branch 5 times, most recently from 8767be2 to 9198be9 Compare November 14, 2023 18:54
@renovate renovate bot force-pushed the renovate/nextcloud-vue-8.x branch from 9198be9 to 1ec12a2 Compare November 17, 2023 21:42
@renovate renovate bot force-pushed the renovate/nextcloud-vue-8.x branch 2 times, most recently from 34a9e33 to b070c37 Compare December 7, 2023 12:29
@renovate renovate bot force-pushed the renovate/nextcloud-vue-8.x branch from b070c37 to 8b49a45 Compare December 8, 2023 04:49
@renovate renovate bot changed the title fix(deps): update dependency @nextcloud/vue to v8 Update dependency @nextcloud/vue to v8 Dec 14, 2023
@renovate renovate bot changed the title Update dependency @nextcloud/vue to v8 fix(deps): update dependency @nextcloud/vue to v8 Dec 24, 2023
@renovate renovate bot force-pushed the renovate/nextcloud-vue-8.x branch from 8b49a45 to f2df6eb Compare December 27, 2023 17:07
@renovate renovate bot force-pushed the renovate/nextcloud-vue-8.x branch from f2df6eb to 65a4b70 Compare January 12, 2024 23:27
@renovate renovate bot force-pushed the renovate/nextcloud-vue-8.x branch 4 times, most recently from 7293606 to 127a287 Compare January 30, 2024 16:40
@renovate renovate bot force-pushed the renovate/nextcloud-vue-8.x branch from a8fe263 to 82829db Compare February 3, 2024 09:19
@enjeck enjeck disabled auto-merge February 4, 2024 09:20
Copy link
Contributor Author

renovate bot commented Feb 4, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@enjeck
Copy link
Contributor

enjeck commented Feb 5, 2024

@juliushaertl I turned off auto-merge here. Lots of changes, want a second look to make sure it's all good


<style scoped>

:deep(.empty-content) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering a bit why we need the :deep() here but not in the other places

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're targeting a child element (I think, not a 100% sure). It doesn't work without this tho

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for checking that so quickly. I left two nitpicks and one additional migration that we should do to the native date time picker component

if (this.value !== null && this.value !== 'none') {
return Moment(this.value, 'HH:mm').toDate()
} else if (this.value === null && this.column.datetimeDefault === 'now') {
const dt = Moment()
this.$emit('update:value', dt.format('HH:mm'))
return dt.toDate()
} else {
return null
return new Date()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this because otherwise, get the error message "TypeError: Cannot destructure property 'yyyy' of 'this.getReadableDate(...)' as it is undefined.", originating from the NcDateTimePickerNative component. The downside of this is it initializes the time to the current time. Which defeats the purpose of having a separate checkbox for Set now as default.
Maybe there's a better way to fix this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a good way for this with the native picker as it does not allow to select an empty value. Maybe we need to change the UI there to have a button to add a date which then shows the selector (and prefills with the current date) and have a button next to it to remove it again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, your approach seems reasonable as I tested and we already have an option to reset with the first branch in line 41

@juliusknorr juliusknorr mentioned this pull request Feb 8, 2024
3 tasks
@enjeck enjeck force-pushed the renovate/nextcloud-vue-8.x branch 2 times, most recently from 8fe2dd7 to 361c96e Compare February 11, 2024 10:53
renovate bot and others added 11 commits February 12, 2024 06:59
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@juliusknorr juliusknorr merged commit 9486b2f into main Feb 12, 2024
39 checks passed
@juliusknorr juliusknorr deleted the renovate/nextcloud-vue-8.x branch February 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants