Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - feat: support multiple tables in store #800

Closed
wants to merge 1 commit into from
Closed

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jan 25, 2024

We want to have multiple tables on the same page

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
const index = rows.findIndex(r => r.id === row.id)
rows[index] = row
commit('setRows', {tableId, rows:[...rows]})
}
return true
},
async insertNewRow({ state, commit, dispatch }, { viewId, tableId, data }) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to figure out how to handle Views. Using the tableId as a key for state.columns and state.rows doesn't really work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't just use the View id as a key, since it might collide with a Table id

@enjeck
Copy link
Contributor Author

enjeck commented Feb 3, 2024

Will split into multiple PRs. Tracking at #807

@enjeck enjeck closed this Feb 3, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant