Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Use table id for events #808

Merged
merged 6 commits into from
Feb 13, 2024
Merged

enh: Use table id for events #808

merged 6 commits into from
Feb 13, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jan 29, 2024

As part of #807. We pass table ids around, for use later to support multiple table instances

@enjeck
Copy link
Contributor Author

enjeck commented Jan 30, 2024

The reason that I'm passing the table ids around is so that they can be used when emitting events. Currently, modals (such as CreateColumn.vue need to know exactly what Table to target, and this is gotten from activeElement stored in the global store. So by passing the table ids around like I've done, we can always specify an active Table and it will work properly, even when there are multiple tables on screen.

We're trying to make NcTable independent, so that it may be moved into the component library someday. So passing the table id as prop in NcTable might jeopardize this.

Not sure if there's a better way (that I understand) to do this.

src/modules/main/sections/MainWrapper.vue Outdated Show resolved Hide resolved
src/shared/components/ncTable/NcTable.vue Outdated Show resolved Hide resolved
src/shared/components/ncTable/sections/CustomTable.vue Outdated Show resolved Hide resolved
@juliushaertl juliushaertl added enhancement New feature or request 2. developing Work in progress labels Feb 1, 2024
@enjeck enjeck force-pushed the enh-emit-id branch 2 times, most recently from 5095637 to 03e05b7 Compare February 12, 2024 06:00
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck enjeck merged commit f2427da into main Feb 13, 2024
39 checks passed
@enjeck enjeck deleted the enh-emit-id branch February 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants