Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): database structure for contexts #841

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Feb 14, 2024

Implements the DB structure as proposed in #812 with these two differences:

  • for consistency, I renamed "resource" to "node" how it is already named in the existing share table
  • for it is not possible to have a column being nullable and part of the primary key, in navigation i changed the user_id to not be nullable and have the default set to an empty string. The intended logic therefore is changed that the default is an empty string, instead of null. Otherwise, same behaviour is envisioned.
  • owner_type is now an int, to be used with constants to be introduced, as discussed

Dedicated indices will be added later on once the queries are standing. Ideally prereleases are not shipped without them being done.

ℹ️ this PR is opened against a feature branch, feat/contexts freshly forked from main. This is because 0.7 is not completed and branched off so far. We can merge it to main either after 0.7 is branched off.

Contributes to #311

@blizzz blizzz added the 3. to review Waiting for reviews label Feb 14, 2024
@blizzz blizzz added this to the Upcoming milestone Feb 14, 2024
@blizzz blizzz added the enhancement New feature or request label Feb 14, 2024
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz merged commit 370379e into feat/contexts Feb 15, 2024
43 checks passed
@blizzz blizzz deleted the enh/812/contexts-db branch February 15, 2024 17:12
@juliushaertl juliushaertl modified the milestones: v0.8.0, v0.7.0 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants