Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hold multiple tables/views in global store #843

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Feb 14, 2024

As part of #807 , we want to hold multiple Tables' data in the vuex store. We do this because the data is needed for various modals to function properly

Todo

  • Consider whether or not to clear the store. In the normal case where we have just one Table or View per page, no need storing all previously-seen Table/View data

@enjeck enjeck self-assigned this Feb 14, 2024
@enjeck enjeck changed the title enh: hold multiple tables/views in global store feat: hold multiple tables/views in global store Feb 14, 2024
@enjeck enjeck force-pushed the enh/multiple-tables-in-store branch from 5ec5919 to 106c94c Compare February 19, 2024 12:20
@enjeck enjeck marked this pull request as ready for review February 19, 2024 12:46
@enjeck enjeck force-pushed the enh/multiple-tables-in-store branch from 106c94c to dc33857 Compare February 19, 2024 12:46
@juliusknorr juliusknorr added enhancement New feature or request 3. to review Waiting for reviews labels Feb 21, 2024
@juliusknorr juliusknorr changed the base branch from main to feat/contexts February 22, 2024 09:11
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@juliusknorr
Copy link
Member

Restarted the failing ci job as it looked like a network issue on the runner

@enjeck enjeck merged commit 5f9387d into feat/contexts Feb 22, 2024
36 checks passed
@enjeck enjeck deleted the enh/multiple-tables-in-store branch February 22, 2024 10:58
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants