Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply fill to path for svg app icon #851

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Feb 15, 2024

The server favicon generation requires a fill on the path to properly render the favicon:

Screenshot 2024-02-15 at 22 08 30

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review Waiting for reviews labels Feb 15, 2024
@juliushaertl juliushaertl added this to the v0.7.0 milestone Feb 15, 2024
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@juliushaertl juliushaertl merged commit 6723aa6 into main Feb 16, 2024
41 checks passed
@juliushaertl juliushaertl deleted the fix/icon-favicon-color branch February 16, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants