-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hide user status from owner avatar (issue #829) #853
Conversation
Signed-off-by: Elizabeth Danzberger <spookystuff@protonmail.com>
Signed-off-by: Elizabeth Danzberger <spookystuff@protonmail.com>
Adjusting other places seems fine, just the share recipients i think it would make sense to keep the status to be consistent with other sharing sidebars (like in files) where we also show the status. Maybe you can just drop that commit. |
@jancborchardt Curious to know some designer feedback on this |
Signed-off-by: Elizabeth Danzberger <spookystuff@protonmail.com>
I think I managed to drop that commit, hopefully I did it correctly without messing anything up :) |
Looks like that worked fine ;) |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Status icon removed from navigation sidebar as illustrated in issue #829
Also removed from other places which I thought were not needed, such as next to the table title, the share list when sharing the table, and the views dashboard:
If these additional changes are unnecessary or should not have been changed, it can easily be rolled back to only remove the icon from the navigation sidebar as shown in the original issue.