feat: Add material design icons for applications #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
added
3. to review
blizzz
reviewed
Mar 5, 2024
| cp $CLONE_PATH/LICENSE $TARGET_PATH/LICENSE | ||
|
|
||
| cat $CLONE_PATH/meta.json | | ||
| jq '.[]|select(.author == "Google" and (.name | contains("-") | not))' > $TARGET_PATH/meta.json |
There was a problem hiding this comment.
Fine for simplicity, but want to point out that some icons are unique while having a dash, for instance cash-100, air-purifier or contactless-payment-circle.
There was a problem hiding this comment.
Yeah we can extend the list later on
blizzz
approved these changes
Mar 5, 2024
|
Part of: #895 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #863 and #896
This PR adds a script that automatically extracts material design icons and metadata based on a jq json filter to tables. For now we can just start with the default google ones stripped down without variants.
We cannot use the npm library as the backend needs to serve the image url for the nativation entries. The json metadata file can be used in the frontend to generate a picker component then.