Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create new table from import #915

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat: create new table from import #915

merged 1 commit into from
Apr 25, 2024

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Mar 8, 2024 •
edited
Loading

@luka-nextcloud luka-nextcloud added enhancement New feature or request 3. to review Waiting for reviews labels Mar 8, 2024
@luka-nextcloud luka-nextcloud self-assigned this Mar 8, 2024
@juliusknorr
Copy link
Member

juliusknorr commented Mar 8, 2024 •
edited
Loading

@luka-nextcloud Feel free to also involve others for review ;) Also some screenshots for designers to check would be nice.

@juliusknorr juliusknorr force-pushed the feature/create-new-table-from-import branch from cdb003c to f663e4a Compare April 19, 2024 13:59
max-nextcloud
max-nextcloud reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that this includes cypress tests. Makes the review much easier.

Please fix them and add the screenshots for design review as proposed by julius.

cypress/e2e/tables-table.cy.js Outdated Show resolved Hide resolved
@luka-nextcloud
feat: create new table from import
71a8ad1 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the feature/create-new-table-from-import branch from f663e4a to 71a8ad1 Compare April 24, 2024 11:38
@juliusknorr juliusknorr added this to the v0.8.0 milestone Apr 24, 2024
@luka-nextcloud
Copy link
Contributor Author

Uploaded a video recording.

@luka-nextcloud luka-nextcloud merged commit e2f69f3 into main Apr 25, 2024
45 checks passed
@luka-nextcloud luka-nextcloud deleted the feature/create-new-table-from-import branch April 25, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@enjeck enjeck Awaiting requested review from enjeck

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

@luka-nextcloud luka-nextcloud

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Import: Create new table from import
3 participants
@luka-nextcloud @juliusknorr @max-nextcloud