Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Focus first input when creating a new table/row/column/view #925

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Mar 12, 2024

Make sure that the modals to create new elements always focus the first input by default.

@juliushaertl juliushaertl added bug Something isn't working 3. to review Waiting for reviews labels Mar 12, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, also gave it a quick test and it works. Gave me the chance to look up nextTick and do a bit of learning :)

@juliushaertl
Copy link
Member Author

Will check the test failure, i think it is just due to the multiselect being automatically focused now

 a new table/row/column/view

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 053b6c0 into main Mar 14, 2024
42 checks passed
@juliushaertl juliushaertl deleted the fix/focus-first-input branch March 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants