feat: Application sharing frontend #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjeck
force-pushed
the
share-context
branch
2 times, most recently
from
ce7c5c7
to
56396a4
Compare
enjeck
commented
Apr 11, 2024
Closed
2 tasks
enjeck
commented
Apr 18, 2024
blizzz
reviewed
Apr 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
blizzz
force-pushed
the
feat/noid/context-sharing
branch
from
96a45f0
to
54cc20c
Compare
blizzz
force-pushed
the
share-context
branch
2 times, most recently
from
1929d95
to
61255b0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
enjeck
force-pushed
the
feat/noid/context-sharing
branch
from
54cc20c
to
d164cb2
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
|
resolved conflicts from rebase |
enjeck
commented
Apr 19, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- that is through the internal endpoints /tables/table and /tables/view Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
blizzz
approved these changes
Apr 23, 2024
enjeck
commented
Apr 23, 2024
Comment on lines
+3
to
+13
| <div class="col-4"> | ||
| {{ t('tables', 'Share with accounts') }} | ||
| </div> | ||
| <NcSelect v-model="preExistingSharees" style="width: 100%;" :loading="loading" :options="options" | ||
| :placeholder="getPlaceholder()" | ||
| :searchable="true" :get-option-key="(option) => option.key" | ||
| label="displayName" | ||
| :aria-label-combobox="getPlaceholder()" :user-select="true" | ||
| :close-on-select="false" | ||
| :multiple="true" | ||
| @search="asyncFind" @input="addShare"> |
There was a problem hiding this comment.
I notice that we already have several NcSelects that search for users/groups duplicated across other pages. Thinking about how to consolidate into just one and reuse
There was a problem hiding this comment.
That would be very nice indeed
There was a problem hiding this comment.
@enjeck Could you file a follow up issue
juliushaertl
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to share contexts as well as permission for associated context resources