-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Migrating from the MaterialPreferences library to native #3063
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
4c52918
to
45d64e7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
For reference, my design changes are based on https://m3.material.io/components/lists |
Looks really nice 👌 |
@rapterjet2004 can you rebase to latest master, else I would have to re-install and loose all accounts? Thanks in advance 💙 |
I noticed that the proxy type box was empty on this version but the default is no proxy |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Ok I just fixed it, I had to reset the app data first. I added this line of code before setting up my drop down |
Perfect! Thank you so much. |
it looks like we have some fun work ahead of us here with merge conflicts. we can do this together if you want @rapterjet2004 |
aab762d
to
9ecf66f
Compare
Signed-off-by: Julius Linus julius.linus@nextcloud.com
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Julius Linus julius.linus@nextcloud.com
Signed-off-by: github-actions <github-actions@github.com>
9ecf66f
to
800e201
Compare
This reverts commit dc7b421b2bdfedc9a71a1b55b87fda4670cfc35e. Revert "rebasing" This reverts commit ad5a4110052ce56ae90d3d9183c393ec59f6d6db. Revert "rebasing" This reverts commit 12b36133948dea1e7529fa7b31f1bd63bf68ca34. Revert "WIP migrating from material preferences to native, working on migrating DatabaseStorageModule" This reverts commit 8fd8e4070816724f3dc55f994ee054c931b49782. Revert "rebasing" This reverts commit 0397c6fbf2c8b84530fa2806ec269680cf01deab. rebasing Signed-off-by: Julius Linus julius.linus@nextcloud.com WIP migrating from material preferences to native, working on migrating DatabaseStorageModule Signed-off-by: Julius Linus julius.linus@nextcloud.com rebasing Signed-off-by: Julius Linus julius.linus@nextcloud.com rebasing Signed-off-by: Julius Linus julius.linus@nextcloud.com rebasing Signed-off-by: Julius Linus julius.linus@nextcloud.com
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3063-talk.apk |
MaterialPreferences is unmaintained and the UI looks dated. This PR is to migrate to a native solution, and adhere to the modern material 3 design. #3050 (comment) This way the app becomes more maintainable in the long run and reduces the use of 3rd party dependencies.
Signed-off-by: Julius Linus julius.linus@nextcloud.com
🖼️ Themed Screenshots
Conversation Info Activity
🏡 After
Settings Activity
🏡 After
🚧 TODO
UI
Back end
🏁 Checklist
/backport to stable-xx.x