Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid file storage permission warning. #3268

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Aug 23, 2023

fix #3267 as followup for #3210

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added this to the 17.1.0 milestone Aug 23, 2023
@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Aug 23, 2023
"Sharing files from storage is not possible without permission" popped up after app startup because notification permission was requested.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the bugfix/3267/avoidFilesPermissionWarning branch from e6e9e0d to bc425bc Compare August 24, 2023 07:47
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3268-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit f5f0ed1 into master Aug 24, 2023
13 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/3267/avoidFilesPermissionWarning branch August 24, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sharing files from storage is not possible without permission" after app startup
2 participants