Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strings for banning #4060

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Fix strings for banning #4060

merged 2 commits into from
Aug 9, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Aug 9, 2024 •
edited
Loading

see https://cloud.nextcloud.com/call/c7fz9qpr#message_3071670

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi
fix strings for banning (use 'participant' instead 'actor')
5f0563a 
replace key ban_actor with ban_participant

fix upper/lower case

fix to use translation in ConversationInfoActivity instead hardcoded string

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
rename layouts for banning
94fbdb2 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added the 3. to review Waiting for reviews label Aug 9, 2024
@mahibi mahibi added this to the 20.0.0 milestone Aug 9, 2024
@mahibi mahibi self-assigned this Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Codacy

Lint

TypemasterPR
Warnings9082
Errors129131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4060-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit a9593f2 into master Aug 9, 2024
18 of 19 checks passed
@mahibi mahibi deleted the fixStringsForBanning branch August 9, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakekniven rakekniven rakekniven approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mahibi @rakekniven