Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last message in Conversation is formatted correctly #4081

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Last message in Conversation is formatted correctly #4081

merged 1 commit into from
Aug 15, 2024

Conversation

rapterjet2004
Copy link
Contributor

Todo

  • Linter errors

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9087
Errors129132

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

@sowjanyakch sowjanyakch self-requested a review August 15, 2024 09:53
@rapterjet2004
Copy link
Contributor Author

/backport to stable-20.0

@rapterjet2004
fix
903dd07 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-4074-conversation-list-bug branch from ad1a10f to 903dd07 Compare August 15, 2024 13:38
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4081-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit 2f251d0 into master Aug 15, 2024
14 of 19 checks passed
@sowjanyakch sowjanyakch deleted the issue-4074-conversation-list-bug branch August 15, 2024 14:09
@backportbot backportbot bot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conversation list no longer shows author's first name
2 participants
@rapterjet2004 @sowjanyakch