Fixing federated acceptance messages #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapterjet2004
added
3. to review
| @@ -3371,7 +3369,7 @@ class ChatActivity : | |||
| CONTENT_TYPE_VOICE_MESSAGE -> message.isVoiceMessage | |||
| CONTENT_TYPE_POLL -> message.isPoll() | |||
| CONTENT_TYPE_LINK_PREVIEW -> message.isLinkPreview() | |||
| CONTENT_TYPE_SYSTEM_MESSAGE -> !TextUtils.isEmpty(message.systemMessage) | |||
| CONTENT_TYPE_SYSTEM_MESSAGE -> message.messageType == "system" | |||
There was a problem hiding this comment.
Any idea why the previous check did not work? Because systemMessage should not be empty in this case?
There was a problem hiding this comment.
Ahh, I see, seems that the federated_user_added and federated_user_removed weren't added to the system message type enum. Should be fixed properly now.
rapterjet2004
force-pushed
the
issue-4072-federated-accept-message-should-be-system
branch
from
0c310dc
to
7ca68b3
Compare
SystemKeeper
approved these changes
Aug 17, 2024
rapterjet2004
deleted the
issue-4072-federated-accept-message-should-be-system
branch
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4086-talk.apk |
|
/backport to stable-20.0 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x