Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-20.0] Fix conversation search functionality and highlighting #4116

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 26, 2024

Backport of PR #4088

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
…e it) as tapping it destroys the searchViewDisposable for some reason

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Aug 26, 2024
@backportbot backportbot bot added this to the 20.0.0 milestone Aug 26, 2024
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8687
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4116-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit 2063e67 into stable-20.0 Aug 26, 2024
11 of 16 checks passed
@sowjanyakch sowjanyakch deleted the backport/4088/stable-20.0 branch August 26, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants