Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/4078/fix self reaction when re entering chat #4162

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 6, 2024

fix #4078

  • also fix switched background colors of self reactions

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added the 3. to review Waiting for reviews label Sep 6, 2024
@mahibi mahibi added this to the 20.1.0 milestone Sep 6, 2024
@mahibi mahibi self-assigned this Sep 6, 2024
= fix type of list in stringToArrayList

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the bugfix/4078/fixSelfReactionWhenReEnteringChat branch from e96fb6a to a0a388c Compare September 6, 2024 12:32
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Codacy

Lint

TypemasterPR
Warnings8692
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

Copy link
Contributor

github-actions bot commented Sep 6, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4162-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 06f5c0b into master Sep 6, 2024
15 of 18 checks passed
@mahibi mahibi deleted the bugfix/4078/fixSelfReactionWhenReEnteringChat branch September 6, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactions aren't saving state when reentering a conversation
2 participants