Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to show user status in conversation list #4221

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix to show user status in conversation list #4221

merged 1 commit into from
Sep 17, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 16, 2024

fix #4219

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added the 3. to review Waiting for reviews label Sep 16, 2024
@mahibi mahibi added this to the 20.1.0 milestone Sep 16, 2024
@mahibi mahibi self-assigned this Sep 16, 2024
@mahibi
Copy link
Collaborator Author

mahibi commented Sep 16, 2024

/backport to stable-20.0

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8695
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

@mahibi
fix to show user status in conversation list
722914f 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the bugfix/4219/fixToShowUserStatus branch from a0732d8 to 722914f Compare September 17, 2024 09:04
@mahibi mahibi merged commit 951c073 into master Sep 17, 2024
12 of 17 checks passed
@mahibi mahibi deleted the bugfix/4219/fixToShowUserStatus branch September 17, 2024 09:05
@backportbot backportbot bot mentioned this pull request Sep 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4221-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

Userstatus didn't show in the Chatlist anymore
1 participant
@mahibi