Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-20.0] fix to load chat for old server version #4229

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 17, 2024

Backport of PR #4223

With server version 23.0.12 it happened that the chat did not load because values were null. Now default values in json model are set (because that's easier than changing the entity).
Additionally a check was added in CallActivity that a callStartTime of 0 would not be used (but it should not be used anyway if it would be 0 because then capability should also not be available).

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@backportbot backportbot bot requested a review from mahibi September 17, 2024 09:00
@backportbot backportbot bot added the 3. to review Waiting for reviews label Sep 17, 2024
@backportbot backportbot bot added this to the 20.0.1 milestone Sep 17, 2024
@mahibi mahibi merged commit 1e5df50 into stable-20.0 Sep 17, 2024
10 of 15 checks passed
@mahibi mahibi deleted the backport/4223/stable-20.0 branch September 17, 2024 09:02
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4229-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant