Conversation creation modification #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowjanyakch
force-pushed
the
conversation_creation_modification
branch
2 times, most recently
from
93e643b
to
38e07e0
Compare
|
/backport to stable-20.0 |
mahibi
reviewed
Sep 20, 2024
| @@ -32,13 +32,20 @@ class ConversationCreationViewModel @Inject constructor( | |||
| val selectedParticipants: StateFlow<List<AutocompleteUser>> = _selectedParticipants | |||
| private val roomViewState = MutableStateFlow<RoomUIState>(RoomUIState.None) | |||
|
|
|||
| private val selectedImageUri = MutableStateFlow<Uri?>(null) | |||
| val selectedImageUriState: StateFlow<Uri?> = selectedImageUri | |||
There was a problem hiding this comment.
mutable property should be prefixed with an underscore (_) and public val should be the same name without underscore:
private val _selectedImageUri = ...
val selectedImageUri StateFlow<Uri?> = _selectedImageUri
sowjanyakch
force-pushed
the
conversation_creation_modification
branch
from
bd47cca
to
93b37ad
Compare
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
mahibi
approved these changes
Sep 23, 2024
mahibi
force-pushed
the
conversation_creation_modification
branch
from
93b37ad
to
8bf9e35
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4250-talk.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4249
This PR implements:
🚧 TODO
🏁 Checklist
/backport to stable-xx.x