Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showing temporary messages when queued #4251

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Showing temporary messages when queued #4251

wants to merge 3 commits into from
+230 −44

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Sep 19, 2024 •
edited
Loading

🖼️ Screenshots

Screenshot 2024-09-19 at 9 26 21 AM

🚧 TODO

  • Got UI working
  • Maintain state on lifecycle changes
  • Allow editing
  • Allow deleting
  • handle replies
  • handle message failed to send
  • fix bugs where messages timeout - might be a room error

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004
git
1c55439 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
added ui
b4bd162 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 self-assigned this Sep 19, 2024
SystemKeeper
SystemKeeper reviewed Sep 20, 2024
View reviewed changes
app/src/main/java/com/nextcloud/talk/adapters/messages/TemporaryMessageViewHolder.kt
/*
* Nextcloud Talk - Android Client
*
* SPDX-FileCopyrightText: 2024 Your Name <your@email.com>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…

app/src/main/res/layout/item_temporary_message.xml
<!--
~ Nextcloud Talk - Android Client
~
~ SPDX-FileCopyrightText: 2023 Julius Linus <juliuslinus1@gmail.com>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably 2024?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy and Pasted 😅

@rapterjet2004
should have fixed the UI now with lifecycle and error handling
26565b6 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4251-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8698
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rapterjet2004 @SystemKeeper