Password improvement

[sowjanyakch]

#Resolves #4235

🚧 TODO

• ...

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

functionality works for me.

Dialog should be material3 design, so rounded corners..
Also for the initial password dialog, only the save button should have primary color.

[sowjanyakch]

This is a screenshot of AlertDialog from material3:

The buttons are basically a text button with text in primary color. I made changes taking it as reference.

Also for the initial password dialog, only the save button should have primary color.

What other color do you want to have for cancel button? I think red looks good.

[mahibi]

This is a screenshot of AlertDialog from material3:

The buttons are basically a text button with text in primary color. I made changes taking it as reference.

Also for the initial password dialog, only the save button should have primary color.

What other color do you want to have for cancel button? I think red looks good.

Current state looks good to me. With the buttons being text only, "cancel" doesn't need to have a different color as suggest by M3 guidelines

[mahibi]

/backport to stable-20.0

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	86	96
Errors	131	131

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	11	11
Dodgy code	79	79
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	109	109

Lint increased!

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4259-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.