Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix wrong value when choosing custom reminder date #4273

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

parneet-guraya
Copy link
Contributor

@parneet-guraya parneet-guraya commented Sep 25, 2024

fix #4248

Before

Record_2024-09-25-22-40-56.mp4

After

Record_2024-09-25-22-39-12.mp4

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
@parneet-guraya parneet-guraya added the 3. to review Waiting for reviews label Sep 25, 2024
@parneet-guraya parneet-guraya self-assigned this Sep 25, 2024
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4273-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8696
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

@mahibi
Copy link
Collaborator

mahibi commented Sep 27, 2024

thank you @parneet-guraya 👍
Also waiting for a review from @rapterjet2004

@mahibi
Copy link
Collaborator

mahibi commented Sep 27, 2024

this also resolves #4099

@parneet-guraya
Copy link
Contributor Author

Nice 👍

@rapterjet2004 rapterjet2004 merged commit 246d496 into master Sep 27, 2024
15 of 19 checks passed
@rapterjet2004 rapterjet2004 deleted the fix-reminder-refactor branch September 27, 2024 14:45
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The selection of a personalized date on the calendar reminder for a message doesn't works correctly.
3 participants