Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time setting for lobby #4368

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Time setting for lobby #4368

merged 4 commits into from
Oct 23, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Oct 22, 2024 •
edited
Loading

fix #1610

  • The lobby time setting can be changed by wiping.
  • Shouldn't set time in the past.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review October 22, 2024 17:50
@sowjanyakch sowjanyakch self-assigned this Oct 22, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Oct 22, 2024
@sowjanyakch
set timer for lobby
71eb97c 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
don't set timer in past
ee445f5 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
ktlintFormat
fda055e 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
remove comments
074297c 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
Copy link
Contributor Author

/backport to stable-20.0

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4368-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9497
Errors132132

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

@sowjanyakch sowjanyakch merged commit d8e12ee into master Oct 23, 2024
18 of 19 checks passed
@sowjanyakch sowjanyakch deleted the time_Setting_for_lobby branch October 23, 2024 14:32
@backportbot backportbot bot mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time setting for lobby does not work well
2 participants
@sowjanyakch @mahibi