-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mac): show window on activate when minimized to tray #894
Conversation
This one. I am used to that behavior from many apps. There is no point in keeping it running in the background when you are not signed in. With its own apps, Apple is more and more quitting macOS apps entirely on their last window close, too. Obviously, that is inappropriate for a chat app. But I would not consider it to be that important difference. |
ac61aa5
to
cf0f61f
Compare
@Ivansss Despite our discussion yesterday but having @i2h3's comment and @SystemKeeper reaction, I went this way.
Is it fine, or you'd insist on reopen for the login window dock icon click? |
cf0f61f
to
e2e709c
Compare
I've tried it. It works like expected. Thank you. |
Actually, after a new discussion with designers, I'm not sure we should close the login window 😣 I'll separate this PR into 2 parts:
|
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
e2e709c
to
190c5e2
Compare
PR is updated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
☑️ Resolves
Additional changes after discussions are forked to #911