Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): show window on activate when minimized to tray #894

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 14, 2024

☑️ Resolves


Additional changes after discussions are forked to #911

@ShGKme ShGKme added bug Something isn't working 3. to review os: macOS 🍎 labels Nov 14, 2024
@ShGKme ShGKme self-assigned this Nov 14, 2024
@i2h3
Copy link

i2h3 commented Nov 14, 2024

Only do that with the main Talk window. Close login window = quit the app

This one. I am used to that behavior from many apps. There is no point in keeping it running in the background when you are not signed in. With its own apps, Apple is more and more quitting macOS apps entirely on their last window close, too. Obviously, that is inappropriate for a chat app.

But I would not consider it to be that important difference.

@ShGKme ShGKme marked this pull request as draft November 15, 2024 00:17
@ShGKme ShGKme force-pushed the fix/activate-window-on-mac branch from ac61aa5 to cf0f61f Compare November 15, 2024 13:33
@ShGKme ShGKme marked this pull request as ready for review November 15, 2024 13:46
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 15, 2024

@Ivansss Despite our discussion yesterday but having @i2h3's comment and @SystemKeeper reaction, I went this way.

  • Talk window - reopen on the Dock icon click (never closed, lives in the system tray)
  • Login/Welcome windows - quit app on window close

Is it fine, or you'd insist on reopen for the login window dock icon click?

@ShGKme ShGKme force-pushed the fix/activate-window-on-mac branch from cf0f61f to e2e709c Compare November 15, 2024 13:55
@ShGKme ShGKme marked this pull request as draft November 15, 2024 14:56
@BJKle
Copy link

BJKle commented Nov 20, 2024

I've tried it. It works like expected. Thank you.

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 20, 2024

Actually, after a new discussion with designers, I'm not sure we should close the login window 😣

I'll separate this PR into 2 parts:

  • Fixing reopening the Talk window
  • Quitting from the login window

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 20, 2024

PR is updated:

@ShGKme ShGKme marked this pull request as ready for review November 20, 2024 10:28
@ShGKme ShGKme requested a review from Antreesy November 20, 2024 10:28
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShGKme ShGKme merged commit 281a7bf into main Nov 20, 2024
11 checks passed
@ShGKme ShGKme deleted the fix/activate-window-on-mac branch November 20, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Once closed, app window opens no more by activation in Dock
4 participants