Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add migration attributes #6177

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 6, 2024

For nextcloud/server#46476

This allows admins to better prepare for upgrades by knowing what database changes are going to happen.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, didn't know about the migration attributes yet.

composer.lock seems to have been commited by accident.

@juliushaertl
Copy link
Member Author

No it was on purpose to update nextcloud/ocp and bump the PHP requirement to 8.1 in the composer file

@juliushaertl juliushaertl merged commit 060343c into main Aug 7, 2024
63 checks passed
@juliushaertl juliushaertl deleted the chore/migration-attributes branch August 7, 2024 12:34
@juliushaertl
Copy link
Member Author

It is so far only supported for shipped apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants