Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] add support for required and recommended nextest versions #919

Merged
merged 4 commits into from
Jul 30, 2023

Conversation

sunshowers
Copy link
Member

@sunshowers sunshowers commented Jul 30, 2023

Also address #903 and #910, and prepare for release.

The cargo_metadata update addresses nextest-rs#910.
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #919 (1ea4b5d) into main (7e0e313) will increase coverage by 0.15%.
The diff coverage is 80.16%.

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   78.44%   78.60%   +0.15%     
==========================================
  Files          61       64       +3     
  Lines       13985    14518     +533     
==========================================
+ Hits        10971    11412     +441     
- Misses       3014     3106      +92     
Files Changed Coverage Δ
cargo-nextest/src/errors.rs 4.73% <0.00%> (-0.27%) ⬇️
cargo-nextest/src/cargo_cli.rs 67.19% <37.25%> (-5.13%) ⬇️
cargo-nextest/src/dispatch.rs 81.96% <67.34%> (-2.09%) ⬇️
nextest-runner/src/show_config/nextest_version.rs 81.39% <81.39%> (ø)
nextest-runner/src/config/nextest_version.rs 98.31% <98.31%> (ø)
cargo-nextest/src/helpers.rs 100.00% <100.00%> (ø)
nextest-runner/src/config/config_impl.rs 93.79% <100.00%> (+0.21%) ⬆️
nextest-runner/src/config/tool_config.rs 94.81% <100.00%> (+0.41%) ⬆️
nextest-runner/src/test_command.rs 97.45% <100.00%> (+0.70%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sunshowers sunshowers force-pushed the next-nextest branch 2 times, most recently from 681bead to 56d231c Compare July 30, 2023 02:22
Can't do this right now because MSRV is still Rust 1.66, but in the
future we'll want to add a test to ensure that `line-tables-only` works
well.

Closes nextest-rs#910.
Since nextest keeps gaining new features, it is important for repository
owners to be able to say "please update nextest" or even "we'll loudly
fail if you don't have a new enough nextest".

* Add support for a `nextest-version` field, inspired by `rust-version`.
* Add documentation.
* Also add tests both internally and for the UI surface.
@sunshowers sunshowers merged commit 5878e10 into nextest-rs:main Jul 30, 2023
13 checks passed
@sunshowers sunshowers deleted the next-nextest branch July 30, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant