Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pod directive to podOptions #2747

Closed
wants to merge 2 commits into from

Conversation

bentsherman
Copy link
Member

This PR renames the pod directive to podOptions, for consistency with clusterOptions, containerOptions, etc. Nextflow will still accept pod but will print a deprecation warning.

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@pditommaso
Copy link
Member

I will the idea, I'd resist making this change only for naming uniformity. I guess there's a lot of config out there that would be impacted and can be annoying to update them.

I would keep this possibility if at some point there's need to change the pod configuration structure or keep in sync with the config re-engineering #2723

@bentsherman
Copy link
Member Author

To be clear, this PR only deprecates the pod option, so pod is still accepted but users get a deprecation warning. Anyway, this PR is here if you want to merge it. Although I left it as a draft because I wanted to make sure I did the deprecation correctly. Still need to test locally.

@pditommaso
Copy link
Member

pditommaso commented Apr 5, 2022

Understand that, but still think we can keep this for when it may be needed to re-organise the K8s config. Also considering the discussion to use jobs instead of pods #2751, does still make sense to use podOptions? maybe it could be better to use k8sOptions instead.

Closing this for now.

@pditommaso pditommaso closed this Apr 5, 2022
@bentsherman
Copy link
Member Author

I think podOptions still makes sense because it refers to the pod-specific options, whether the pod is standalone or part of a job. k8sOptions would be confusing with the k8s config options, we would want to rethink how the k8s options are organized overall.

@bentsherman bentsherman deleted the ben/rename-pod-directive branch August 25, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants