-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pipe for dump
operator
#4176
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding some unit tests
I added a unit test. Strangely, the unit test fails but it works when I run it as a script: $ cat dump.nf
Channel.of(1, 2, 3) | dump
$ ../launch.sh run dump.nf -dump-channels
N E X T F L O W ~ version 23.08.0-edge
Launching `dump.nf` [condescending_torricelli] DSL2 - revision: eac5d3d36c
[DUMP] 1
[DUMP] 2
[DUMP] 3 |
097949f
to
488c22d
Compare
81f7cb7
to
8a43489
Compare
It's already possible to do
What you are tying to fix here? |
To make the pipe syntax work: channel.of(1,2,3)
| dump
| map(it -> it*2)
| view |
dump
operator
dump
operatordump
operator
Moving to draft since tests fails |
Closing in favor of v2 operator library |
Makes the
dump
operator behave like an actual operator (i.e. chainable) by moving it toOperatorImpl
.