Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.md - mention string or map #5316

Closed
wants to merge 2 commits into from
Closed

Conversation

ewels
Copy link
Member

@ewels ewels commented Sep 20, 2024

See #5314 (comment)

Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
@ewels ewels requested a review from a team as a code owner September 20, 2024 11:45
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 867ec85
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66efe2b2faa0520008c57c6b
😎 Deploy Preview https://deploy-preview-5316--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -1229,7 +1229,7 @@ The `manifest` scope allows you to define some meta-data information needed when
The following settings are available:

`manifest.author`
: Project author name (use a comma to separate multiple names).
: Project author name (String or map).
Copy link
Member

@bentsherman bentsherman Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: Project author name (String or map).
: Project author(s). Can be a string of comma-separated values or a list of maps.

docs/config.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
@@ -1256,7 +1256,7 @@ The following settings are available:
: Project main script (default: `main.nf`).

`manifest.maintainer`
: Project maintainer(s) (String or map).
: Project maintainer(s). Can be a string of comma-separated values or a list of maps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this is declared as a String

String getAuthor() {
target.author
}

We could use comma separate string for more than one author as for maintainer (map becomes a mess to handle on backend side)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is following this comment: #5314 (comment) and originally #4034 (comment)

Essentially for both author and maintainer fields, I'd like to be able to optionally specify a number of fields:

  • Name
  • Email
  • Affiliation
  • ORCiD
  • GitHub

..for multiple authors / maintainers.

Having this info would allow us to roll it into other provenance outputs, like BCO and RO Crate. Which would in turn give rich authorship information in downstream platforms like WorkflowHub, Seqera Pipelines, the nf-core website and more. We could also build automation to fill it from GitHub contribution statistics in @nf-core and other nice stuff.

The string is simple, but not really useful. People put all kinds of things in there in different formats and so it's impossible to use for anything downstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important deviation from what was implemented. Not sure any more all those should the manifest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is true the author is declared as a string, so we can't re-use it. We'll have to add a new field like authors and maintainers, maybe deprecate the old ones

But we really do need more detailed fields for the author list so that it can be easily mapped to provenance manifests like BCO

@ewels
Copy link
Member Author

ewels commented Sep 24, 2024

Closing in favour of #5322

@ewels ewels closed this Sep 24, 2024
@ewels ewels deleted the manifest.author---docs-tweak branch September 24, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants