-
Notifications
You must be signed in to change notification settings - Fork 753
Add support for gcp ops agent #6608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add a new configuration option google.batch.installOpsAgent that enables the installation of the Ops Agent on Google Batch instances for enhanced monitoring and logging capabilities. Changes include: - Add installOpsAgent config field to BatchConfig - Update GoogleBatchTaskHandler to set installOpsAgent in allocation policy - Add test coverage for the new configuration option - Update documentation in config.md Signed-off-by: ejseqera <esha.joshi@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: ejseqera <esha.joshi@seqera.io>
7b8b468 to
8e2c0d4
Compare
| instancePolicyOrTemplate.setPolicy( instancePolicy ) | ||
| } | ||
|
|
||
| if( batchConfig.installOpsAgent ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it check if the boot disk image is compatible with the Ops Agent?
| `google.batch.installOpsAgent` | ||
| : Enable the installation of the Ops Agent on Google Batch instances for enhanced monitoring and logging (default: `false`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any good google cloud docs we could link to? I found this which seems okay
| : List of custom mount options for `gcsfuse` (default: `['-o rw', '-implicit-dirs']`). | ||
|
|
||
| `google.batch.installOpsAgent` | ||
| : Enable the installation of the Ops Agent on Google Batch instances for enhanced monitoring and logging (default: `false`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| : Enable the installation of the Ops Agent on Google Batch instances for enhanced monitoring and logging (default: `false`). | |
| : Enables Ops Agent installation on Google Batch instances for enhanced monitoring and logging (default: `false`). |
I think the sentence could be simplified. Please check meaning is retained.
Add support for installing the Google Cloud Ops Agent on Google Batch instances through a new configuration option
google.batch.installOpsAgent. OpsAgent on GCP helps provide telemetry and monitoring info on VM instances like CPU, memory, disk I/O metrics.Changes
installOpsAgentconfig option toBatchConfigGoogleBatchTaskHandlerto includeinstallOpsAgentin the allocation policy API requestTest with:
Resultant jobs will use
batch-debianas the OS and the Batch job logs will show installation of the OpsAgent.