Fix String.format error when plugin URL contains percent chars #6651
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escape '%' characters to '%%' in the error message when a connection exception occurs in HttpPluginRepository. This prevents String.format interpretation errors in PluginRuntimeException when the URI contains URL-encoded characters (e.g., %20 for spaces). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
reviewed
Dec 12, 2025
modules/nf-commons/src/main/nextflow/plugin/HttpPluginRepository.groovy
Outdated
Show resolved
Hide resolved
…ry.groovy [ci fast] Co-authored-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
bentsherman
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
%characters to%%in error messages thrown byHttpPluginRepositorywhen a connection exception occursString.formatinterpretation errors inPluginRuntimeExceptionwhen the URI contains URL-encoded characters (e.g.,%20for spaces)Test plan
handle prefetch error with percent chars in error messagepassesHttpPluginRepositoryTesttests pass🤖 Generated with Claude Code