Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nmc/2058-generalsettings_dataprivacy_updates #26

Closed
wants to merge 32 commits into from
Closed

Nmc/2058-generalsettings_dataprivacy_updates #26

wants to merge 32 commits into from

Conversation

AnkurBavisa
Copy link

General Settings: dataprivacy

  1. moved up the area "aktualisierungen" / "Updates"
  2. removed(hide) kanal dropdown / Channel dropdown,
  3. moved down the area "about" with new name "data privacy"
  4. added the checkbox "Nutzungsdaten übertragen" /"Transfer usage data".
  5. Added links 'Impressum' / 'Imprint', 'Datenschutz Bestimmungen' / 'Privacy policy' and 'Verwendete Open Source Software' / 'Used open source software',.
    DataPrivacy_Updates
    Settings – general current
    Settings – general

@AnkurBavisa AnkurBavisa added the custom MagentaCLOUD customisation label May 26, 2023
github-actions[bot]
github-actions bot previously requested changes May 26, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

test/testconfigfile.cpp Outdated
};

QTEST_MAIN(TestConfigFile)
#include "testconfigfile.moc"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
testconfigfile.moc file not found

test/testgeneralsettings.cpp Outdated
};

QTEST_MAIN(TestGeneralSettings)
#include "testgeneralsettings.moc"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
testgeneralsettings.moc file not found

@AnkurBavisa AnkurBavisa changed the title Nmc/2058 generalsettings dataprivacy updates Nmc/2058-generalsettings_dataprivacy_updates Jun 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023 •
edited
Loading

Codecov Report

Merging #26 (328a393) into master (bf0a39c) will decrease coverage by 0.05%.
The diff coverage is 4.76%.

❗ Current head 328a393 differs from pull request most recent head 9105481. Consider uploading reports for the commit 9105481 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   60.08%   60.03%   -0.05%     
==========================================
  Files         145      145              
  Lines       18715    18730      +15     
==========================================
  Hits        11244    11244              
- Misses       7471     7486      +15
Impacted Files Coverage Δ
src/libsync/theme.cpp 19.17% <0.00%> (+0.10%) ⬆️
src/libsync/configfile.cpp 25.58% <5.00%> (-0.74%) ⬇️

... and 2 files with indirect coverage changes

@AnkurBavisa AnkurBavisa removed the custom MagentaCLOUD customisation label Jun 16, 2023
@TSI-pranalideshpande TSI-pranalideshpande added custom MagentaCLOUD customisation approved labels Jun 22, 2023
@TSI-parulsharma TSI-parulsharma force-pushed the nmc/2058-generalsettings_dataprivacy_updates branch from ddcc7aa to c17c991 Compare June 23, 2023 11:06
@AnkurBavisa AnkurBavisa force-pushed the nmc/2058-generalsettings_dataprivacy_updates branch 2 times, most recently from 4fc6be5 to 20c9188 Compare June 26, 2023 12:00
@github-actions github-actions bot dismissed their stale review July 5, 2023 11:45

No clang-tidy warnings found so I assume my comments were addressed

@AnkurBavisa AnkurBavisa force-pushed the nmc/2058-generalsettings_dataprivacy_updates branch from 9105481 to 64a3617 Compare July 10, 2023 08:24
@AnkurBavisa AnkurBavisa force-pushed the nmc/2058-generalsettings_dataprivacy_updates branch 2 times, most recently from 3932879 to f44697c Compare July 11, 2023 10:03
@AnkurBavisa AnkurBavisa force-pushed the nmc/2058-generalsettings_dataprivacy_updates branch from f44697c to 66555a6 Compare July 13, 2023 06:21
@tsdicloud tsdicloud added ziteration25 This doesn't seem right and removed custom MagentaCLOUD customisation labels Aug 15, 2023
@memurats memurats closed this Sep 30, 2024
@memurats memurats deleted the nmc/2058-generalsettings_dataprivacy_updates branch September 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

Assignees
No one assigned
Labels
ziteration25 This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@AnkurBavisa @codecov-commenter @tsdicloud @TSI-parulsharma @TSI-pranalideshpande @memurats @rhtot @nextcloud-bot @allexzander @DimitriPapadopoulos